[13.0][MIG] l10n_th_withholding_tax_report #81
Conversation
report_backend widget. These missing two function in the widget cause two bugs in the Odoo Client. (tested on Odoo Enterprise Version). 1. The bug occor when we are on Withholding Tax Report view page, then "click" on "Home menu" (located on the top left of the screen). This bug is caused by missing of on_detach_callback. 2. The bug occor when we are on Withholding Tax Report view page and then we "refresh" the page (pressing F5 or CTRL+R). This bug is caused by missing of on_attach_callback.
|
@kongrattapong before I move on with the review. I think, to generate TXT file, we should use report_csv instead of xlsx_import_export. This is to make things more inline (qweb, xlsx, txt to use same technique). Can you,
Thanks! |
kongrattapong
force-pushed
the
13.0-mig-l10n_th_withholding_tax_report
branch
3 times, most recently
from
5539cc7
to
d4fe32b
Compare
kongrattapong
force-pushed
the
13.0-mig-l10n_th_withholding_tax_report
branch
from
d4fe32b
to
864bc93
Compare
|
@kittiu Sorry for late reply. thank for your review. |
|
Please rebase |
|
rebase already. |
|
@kongrattapong, we can continue this case, only report_csv left, we will try to push it up. |
|
@kongrattapong all modules needed are merged. Can you rebase please? |
Tax report to be more correct, when working with account_document_reversal
File "/home/odoo/src/user/l10n_th_tax_invoice/models/account_move.py", line 98, in create vals["payment_id"] = self._context["payment_id"] TypeError: list indices must be integers or slices, not str
report_backend widget. These missing two function in the widget cause two bugs in the Odoo Client. (tested on Odoo Enterprise Version). 1. The bug occor when we are on Withholding Tax Report view page, then "click" on "Home menu" (located on the top left of the screen). This bug is caused by missing of on_detach_callback. 2. The bug occor when we are on Withholding Tax Report view page and then we "refresh" the page (pressing F5 or CTRL+R). This bug is caused by missing of on_attach_callback.
…ecosoft-odoo/l10n-thailand into 13.0-mig-l10n_th_withholding_tax_report ู
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at b44c943. Thanks a lot for contributing to OCA. ❤️ |
Work in progress
========================