Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_margin_security: Migration to version 16.0 #168 #173

Merged
merged 15 commits into from
Jun 10, 2023

Conversation

hugo-cordoba
Copy link

[16.0][MIG] sale_margin_security

chienandalu and others added 14 commits June 5, 2023 10:18
In sale_margin, when the line already exists, the purchase_price
is computed with the product onchange method, so if the user doesn't
have the field available in the view it's not going to get the right
price. This should be fixed in v13 with the new compute fields
possibilities.
Currently translated at 100.0% (2 of 2 strings)

Translation: margin-analysis-13.0/margin-analysis-13.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-sale_margin_security/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: margin-analysis-15.0/margin-analysis-15.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-15-0/margin-analysis-15-0-sale_margin_security/
@hugo-cordoba hugo-cordoba force-pushed the 16.0-mig-sale_margin_security branch from 0a722fd to b36fefd Compare June 5, 2023 11:00
@hugo-cordoba hugo-cordoba mentioned this pull request Jun 5, 2023
10 tasks
@aliciagaarzo aliciagaarzo force-pushed the 16.0-mig-sale_margin_security branch 2 times, most recently from 0fc1fc8 to aa6a3a2 Compare June 5, 2023 13:13
@hugo-cordoba hugo-cordoba force-pushed the 16.0-mig-sale_margin_security branch from aa6a3a2 to 7d499b3 Compare June 5, 2023 15:00
@hugo-cordoba hugo-cordoba changed the title 16.0 mig sale margin security [16.0][MIG] sale_margin_security: Migration to version 16.0 #168 Jun 5, 2023
@flalexg
Copy link

flalexg commented Jun 5, 2023

Code LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration sale_margin_security

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 10, 2023
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-173-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ddd9050 into OCA:16.0 Jun 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cf8a578. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.