[10.0][BCK] attribute_set #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sponsor
Contributor
rousseldenis
commented
Jun 11, 2020
•
rousseldenis
commented
- Removed draft modules
- fix fields_view_get
- fix tests: unlink() call on ir.model.fields will call self._cr.commit() which is not patched. Use _force_unlink in the context.
New organization : - attribute_set (former base_custom_attribute) - product_attribute_set (former pim_custom_attribute but without menus) - pim (The "PIM application" former pim_base) - pim_attrubute_set (depends on product_attribute_set and adds menus in the PIM application)
And small FIX in _build_attribute_field()
rousseldenis
force-pushed
the
10.0-bck-attribute_set-dro
branch
from
62c7be7
to
7f655d1
Compare
rousseldenis
force-pushed
the
10.0-bck-attribute_set-dro
branch
from
e86bb8b
to
94430c1
Compare
Codecov Report
@@ Coverage Diff @@
## 10.0 #13 +/- ##
===========================================
+ Coverage 52.36% 64.64% +12.28%
===========================================
Files 10 6 -4
Lines 254 297 +43
===========================================
+ Hits 133 192 +59
+ Misses 121 105 -16
Continue to review full report at Codecov.
|
This was referenced Jun 12, 2020
Merged
Cedric-Pigeon
approved these changes
Jun 16, 2020
fields_view_get needs to enrich 'fields' entry too
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 872994a. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.