[ADD][9.0] hr contract operating unit #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message is misleading (this is not expense but contract model). Other than that 👍 ! |
elicoidal
suggested changes
Sep 15, 2016
| * Security rules are defined to ensure that users can only see the Contracts of that Operating Units in which they are allowed access to. | ||
|
|
||
|
|
||
| Installation |
There was a problem hiding this comment.
Remove the following 2 sections if empty
| <!-- Copyright 2015 Eficent Business and IT Consulting Services S.L. | ||
| Serpent Consulting Services Pvt. Ltd. | ||
| License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl-3.0) --> | ||
| <openerp> |
There was a problem hiding this comment.
Should I do the same in the views files?
|
I apologize for the commit message. Thank you @elicoidal |
2 similar comments
12 tasks
AaronHForgeFlow
force-pushed
the
9.0-hr_contract_operating_unit
branch
from
bcb5000
to
9702277
Compare
|
@elicoidal can you please review again? |
elicoidal
approved these changes
Feb 10, 2017
| This module introduces the following features: | ||
|
|
||
| * Adds the Operating Unit (OU) to the Employee Contract. | ||
|
|
There was a problem hiding this comment.
Done. Thank you @elicoidal
|
|
||
| * Adds the Operating Unit (OU) to the Employee Contract. | ||
|
|
||
| * Security rules are defined to ensure that users can only see the Contracts of that Operating Units in which they are allowed access to. |
There was a problem hiding this comment.
non blocking but better to stick to 80 char lines
AaronHForgeFlow
force-pushed
the
9.0-hr_contract_operating_unit
branch
from
99343eb
to
f7e69a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HR Contract with Operating Units
This module introduces the following features: