Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][partner_contact_department] Add departments to contacts #229

Merged
merged 15 commits into from Dec 22, 2015

Conversation

@Yajo
Copy link
Member

Yajo commented Dec 21, 2015

Reopening #228 and OCA/department#51.

This module extends the functionality of the address book to support departments.

Department is a drop-down field in partner forms, and it refers to contact department in its own company.

@JavierIniesta @rafaelbn @dreispt @pedrobaeza @antespi

@rafaelbn

This comment has been minimized.

Copy link
Member

rafaelbn commented Dec 21, 2015

Tested in runbot with base database, http://3137766-229-4a1c1d.runbot2.odoo-community.org

👍 thanks!

Please @JavierIniesta review, thanks!


To use this module, you need to:

* Go to any partner's form.

This comment has been minimized.

Copy link
@pedrobaeza

pedrobaeza Dec 22, 2015

Member

Explain in which tab do you find the department

This comment has been minimized.

Copy link
@rafaelbn

rafaelbn Dec 22, 2015

Member

It's too obvious to explain this

2015-12-22_15-43-50

This comment has been minimized.

Copy link
@pedrobaeza

pedrobaeza Dec 22, 2015

Member

Maybe not. You are the one that always ask for detailed explanations. Saying "You'll find the field below Job position" is enough.

This comment has been minimized.

Copy link
@Yajo

Yajo Dec 22, 2015

Author Member

Fixed.

@pedrobaeza

This comment has been minimized.

Copy link
Member

pedrobaeza commented Dec 22, 2015

Little nitpick, but 👍

@JavierIniesta

This comment has been minimized.

Copy link

JavierIniesta commented Dec 22, 2015

Tested in runbot 👍

@JMODaERP

This comment has been minimized.

Copy link

JMODaERP commented Dec 22, 2015

I test in runbot 👍

@Yajo

This comment has been minimized.

Copy link
Member Author

Yajo commented Dec 22, 2015

3 x 👍 + nitpick fixed = LGTM please! 😊

rafaelbn added a commit that referenced this pull request Dec 22, 2015
[8.0][partner_contact_department] Add departments to contacts
@rafaelbn rafaelbn merged commit b125772 into OCA:8.0 Dec 22, 2015
0 of 2 checks passed
0 of 2 checks passed
ci/runbot runbot build 3137817-229-7cb723
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@yvaucher yvaucher removed the needs review label Dec 22, 2015
@Yajo Yajo deleted the Yajo:department branch Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.