9.0 [MIG] partner_contact_job_position migration #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed crm_job_position to partner_contact_job_position. - Drop all CRM dependencies. - Improve README. - Add form view. - Rename one model. - Rename some fields. - Reorder module. - Remove pot. - Update translation. - Use new-style short license and copyright headers.
pedrobaeza
requested changes
Nov 7, 2016
| Images | ||
| ------ | ||
|
|
||
| * `Antiun Ingeniería S.L. <http://www.antiun.com>`_: Icon. |
There was a problem hiding this comment.
This icon link is not correct.
| "version": "9.0.1.0.0", | ||
| 'category': 'Customer Relationship Management', | ||
| "website": "http://www.antiun.com", | ||
| 'author': 'Serv. Tecnolog. Avanzados - Pedro M. Baeza, ' |
There was a problem hiding this comment.
Switch to Tecnativa both website and author.
| _description = "Job position" | ||
|
|
||
| name = fields.Char(required=True, translate=True) | ||
| parent_id = fields.Many2one( |
There was a problem hiding this comment.
Well, if you use something like https://github.com/odoo/odoo/blob/af865c2e9ea1dc1890ef33add9a6e4bc657068e0/addons/hr/hr.py#L264, there's no need for the test, as this method is already tested.
|
cc @Tecnativa |
yajo
approved these changes
Nov 9, 2016
|
@cubells, please make the changes I requested. |
cubells
force-pushed
the
9.0-mig-partner_contact_job_position
branch
from
5453285
to
fe2c96b
Compare
pedrobaeza
approved these changes
Nov 9, 2016
* Changed icon
* Change author and web
* Check recursion
pedrobaeza
force-pushed
the
9.0-mig-partner_contact_job_position
branch
from
f57815d
to
03bab9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.