New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] Port pos_pricelist to 9.0 #83

Closed
wants to merge 40 commits into
base: 9.0
from

Conversation

Projects
None yet
@x620
Copy link

x620 commented Feb 29, 2016

No description provided.

x620
@oca-clabot

This comment has been minimized.

Copy link

oca-clabot commented Feb 29, 2016

Hey @x620, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • @x620 (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza referenced this pull request Feb 29, 2016

Open

Migration to version 9.0 #58

1 of 10 tasks complete
<!--</tree>-->
<!--</field>-->
<!--</page>-->
<!--</page>-->

This comment has been minimized.

@legalsylvain

legalsylvain Feb 29, 2016

Contributor

Hi,

Could your remove this commented useless part of code ?

- name: 5% Discount on all Computer related products (Qty 2)
sequence: 1
min_quantity: 2
base: 1
# base: 1

This comment has been minimized.

@legalsylvain

legalsylvain Feb 29, 2016

Contributor

same here, useless line I guess.

@legalsylvain legalsylvain added this to the 9.0 milestone Feb 29, 2016

@legalsylvain

This comment has been minimized.

Copy link
Contributor

legalsylvain commented Feb 29, 2016

Hi @x620,
Thanks for porting this important module CC AdilHoumadi ! You marked the last commit with 'WIP' tag. is this PR still Work in progress or do you review review ?
some other comment inline.

Other points, You can take a look on the following PR that improve the V8 version :

Maybe you could git cherry-pick all / some commits done against V8, since V9 branches has been created.

Thanks again and kind regards.

antespi and others added some commits Sep 29, 2015

[IMP] Show unit price when qty is not 1
Conflicts:
	pos_pricelist/__openerp__.py

(cherry-pick commit: e9ac0d5)
[IMP] Preserve manually modified price in most cases
Conflicts:
	pos_pricelist/static/src/js/models.js

(cherry-pick commit: a10bc11)
x620
@oca-clabot

This comment has been minimized.

Copy link

oca-clabot commented Mar 3, 2016

Hey @x620,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

x620 added some commits Mar 3, 2016

x620
x620
Corrected error: TypeError: Cannot read property 'field' of undefined…
… (and many others before it)

Error occurred: TypeError: Cannot read property 'models' of undefined (in progress)
var round_pr = models.round_precision;
var round_di = models.round_decimals;

PosDB = PosDB.extend({

This comment has been minimized.

@yelizariev

yelizariev Mar 9, 2016

Member

Move this block to db.js

@x620

This comment has been minimized.

Copy link

x620 commented Mar 10, 2016

During running the application an errors does not appear. What to look for and what to consider in order to be sure that the application works correctly?

x620 added some commits Mar 10, 2016

x620
Corrected error: AttributeError: 'float' object has no attribute 'dec…
…imal_places'

Corrected error: KeyError: 'total'
x620
@flotho

This comment has been minimized.

Copy link
Member

flotho commented Mar 11, 2016

Hi @x620 @yelizariev ,

I've made some additional test in your db.
We have a pricelist : http://3143544-83-bcbce2.runbot1.odoo-community.org/web#id=3&view_type=form&model=product.pricelist&menu_id=113&action=122
And agrolait is affected to the pricelist : http://3143544-83-bcbce2.runbot1.odoo-community.org/web#id=7&view_type=form&model=res.partner&menu_id=68&action=54
Yet when selling products of the pricelist for agrolait in the POS the price si not discounted.
Could it come from the fact that the list price item is based on template instead of variant?
I also made some tests :

  • First line is on variant
  • second on template
  • Rest as a global fucntion with discount

None of those rules are applied

x620 added some commits Mar 15, 2016

@flotho

This comment has been minimized.

Copy link
Member

flotho commented Mar 15, 2016

Hi @x620 ,

Do you want us to make additionnal tests?

@x620

This comment has been minimized.

Copy link

x620 commented Mar 15, 2016

Hi flotho.
Yet only tooltips.

@flotho

This comment has been minimized.

Copy link
Member

flotho commented Mar 15, 2016

Ok, we'll wait, did you got the test use cases we made ?

regards

@x620

This comment has been minimized.

Copy link

x620 commented Mar 15, 2016

Yes. Thanks

@flotho

This comment has been minimized.

Copy link
Member

flotho commented Mar 15, 2016

Thanks to you!

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Apr 29, 2016

@flotho it's not a big difference between .call and .apply

You can find an example of wrong way to add fields here - https://github.com/yelizariev/pos-addons/blob/8.0/tg_pos_enhanced/static/src/js/tg_pos.js#L17
-- it comletly overwrites load_server_data function

@StefanRijnhart

This comment has been minimized.

Copy link
Member

StefanRijnhart commented Apr 29, 2016

@yelizariev looks like it, except for the definition of the display_price_with_taxes field, which is another side feature of this module.

@flotho

This comment has been minimized.

Copy link
Member

flotho commented May 2, 2016

@x620 , @yelizariev

From my point of view, it works !

@phoenixsampras

This comment has been minimized.

Copy link

phoenixsampras commented May 20, 2016

Awesome work!! please keep it on!! this is so necessary for supermarkets...

@woepwoep

This comment has been minimized.

Copy link

woepwoep commented May 21, 2016

pls connect with me re supermarkets
i am in the food cooperative industry, helping to build a movement here in
the Netherlands.
contact details below
thx, Ron
web: www.voedsel.coop
email: info@voedsel.coop
phone: +31 629 584 582


http://about.me/woepwoep

2016-05-20 5:01 GMT+02:00 phoenixsampras notifications@github.com:

Awesome work!! please keep it on!! this is so necessary for supermarkets...


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#83 (comment)

@flotho

This comment has been minimized.

Copy link
Member

flotho commented May 22, 2016

@yelizariev ,

I have a remark regarding performances. I think it becomes useless to add supplierinfo in the POS.
Actually, the default behaviour of pricelist don't use supplierinfo anymore as way of computing prices.
What is your point of view?

regards

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Jun 2, 2016

I suggest to try merge this PR to new branch, say 9.0-pos_pricelist. This could simplify contributing by other developers. If someone find issue and find a way to fix, one will be able to create new PR instead of asking @x620 and wait when he update his PR.

See discussion on twitter: https://twitter.com/jgrandguillaume/status/735738547118825475

The same approach could be applied to other PR with needs review status

x620
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 6, 2016

Coverage Status

Coverage remained the same at 50.588% when pulling a304da5 on x620:pos-9.0-pos_pricelist into 3ad65ea on OCA:9.0.

@gaelTorrecillas

This comment has been minimized.

Copy link

gaelTorrecillas commented Jun 15, 2016

hello,

@yelizariev in your models.js, the function models.PosModel.extend's initialize returns nothing, why?
When I have to overload this function, I put "return _super_posmodel.initialize.call(this, session, attributes);"
I understand that you used .apply but we don't return _super_posmodel.initialize.apply(this, arguments) ?

@gaelTorrecillas

This comment has been minimized.

Copy link

gaelTorrecillas commented Jun 24, 2016

thanks x620 for your job.

I have other question, in
https://github.com/x620/pos/blob/pos-9.0-pos_pricelist/pos_pricelist/static/src/js/models.js#L262

the function "can_be_merged_with", why the inherit? because, if the products don't have the same id, the core returns false, and if the products' price aren't the same, the core returns false.
do we want save the inherit or if we don't save it, the point of sale will not have the problem?

@dcoopennet

This comment has been minimized.

Copy link

dcoopennet commented Sep 14, 2016

@x620 Is this PR going to be merged ? We need this PORT for one of our customers.
I can review it if you want.

@rafaelbn rafaelbn changed the title Port pos_pricelist to 9.0 [MIG] Port pos_pricelist to 9.0 Dec 14, 2016

@rafaelbn

This comment has been minimized.

Copy link
Member

rafaelbn commented Dec 14, 2016

Hi @x620 , thanks a lot for this PR, thanks all for revisions. This PR is amazing! 😄

Sorry for the late.

Please @x620 could you rebase to check again what's going on with travis?

Also it could be useful is you check this FIX: #100 made by @llacroix in v8

Thanks again!

@rafaelbn

This comment has been minimized.

Copy link
Member

rafaelbn commented Dec 14, 2016

Hi again, as commented by @yelizariev in #83 (comment) after rebase we will check travis and runbot but we can merge if all is green. cc @x620 @legalsylvain

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Dec 14, 2016

@rafaelbn
Pavel (@x620) is out of business and would not make updates. So, it's probably better to create new PR with rebasing and other updates. Can you do it yourself?

@rafaelbn

This comment has been minimized.

Copy link
Member

rafaelbn commented Dec 14, 2016

I cannot myself, but I could ask in my team. In this moment we don't need this but I wish we will. If someone is interested in POS in v9 then could do it. Let wait sometime then.

@rafaelbn

This comment has been minimized.

Copy link
Member

rafaelbn commented Jun 8, 2017

Hi all! Is anyone interested in this PR which is a migration from v8 to v9 of pos_pricelist. If not I will close this PR. Thanks!

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

pedrobaeza commented Jun 8, 2017

As a side note, Odoo v11 include this functionality in core.

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

pedrobaeza commented Feb 22, 2018

Closing this in favor of #186

@pedrobaeza pedrobaeza closed this Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment