[10.0] add new module to manage seasonal products #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cedric-Pigeon
force-pushed
the
10.0-product_life_period-cpi
branch
2 times, most recently
from
5dccc09
to
d1cb02d
Compare
Cedric-Pigeon
force-pushed
the
10.0-product_life_period-cpi
branch
from
2404c1b
to
f33f71e
Compare
|
@Cedric-Pigeon Is this still applicable ? |
|
@rousseldenis Yes we still use it |
rousseldenis
requested changes
Dec 14, 2020
product_life_period/__manifest__.py
Outdated
| "version": "10.0.1.0.0", | ||
| 'author': "Acsone SA/NV, Odoo Community Association (OCA)", | ||
| "category": "Product", | ||
| "website": "http://www.acsone.eu", |
There was a problem hiding this comment.
Please change this key
| end_life_periods = self.search( | ||
| [('end_date', '<=', fields.Date.today())]) | ||
| for end_life_period in end_life_periods: | ||
| end_life_period.product_ids.write({'state': 'end'}) |
There was a problem hiding this comment.
Build product ids set and write on all once.
rousseldenis
force-pushed
the
10.0-product_life_period-cpi
branch
from
aeb1281
to
2199d7c
Compare
Change OCA website Add indexes Prefer using set of product ids to write once
rousseldenis
force-pushed
the
10.0-product_life_period-cpi
branch
from
2199d7c
to
7747727
Compare
|
@LoisRForgeFlow Could you update your review ? |
rousseldenis
approved these changes
Dec 22, 2020
lmignon
approved these changes
Jan 4, 2021
|
This PR has the |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 016b721. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #117 and adapted to V10