Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] add new module: business_requirement #179

Closed

Conversation

Projects
None yet
5 participants
@victormmtorres
Copy link

commented May 27, 2016

Changes to be committed:
new file: business_requirement/README.rst#
new file: business_requirement/init.py
new file: business_requirement/openerp.py
new file: business_requirement/data/business_data.xml
new file: business_requirement/data/business_sequence.xml
new file: business_requirement/models/init.py
new file: business_requirement/models/business.py
new file: business_requirement/security/ir.model.access.csv
new file: business_requirement/security/security.xml
new file: business_requirement/static/description/icon.png
new file: business_requirement/static/img/bus_req.png
new file: business_requirement/static/img/bus_req_alias.png
new file: business_requirement/static/img/bus_req_approved.png
new file: business_requirement/static/img/bus_req_cancel.png
new file: business_requirement/static/img/bus_req_confirmed.png
new file: business_requirement/static/img/bus_req_cust_story.png
new file: business_requirement/static/img/bus_req_done.png
new file: business_requirement/static/img/bus_req_drop.png
new file: business_requirement/static/img/bus_req_module_diag.png
new file: business_requirement/static/img/bus_req_tags.png
new file: business_requirement/static/img/bus_req_tags2.png
new file: business_requirement/static/img/bus_req_tree.png
new file: business_requirement/static/img/module_diag.graphml
new file: business_requirement/tests/init.py#
new file: business_requirement/tests/test_br.py
new file: business_requirement/views/business_viw.xml
new file: business_requirement/wizards/init.py
new file: business_requirement/wizards/mail_compose_message.py

victor
[ADD] add new module: business_requirement
 Changes to be committed:
	new file:   business_requirement/README.rst#
	new file:   business_requirement/__init__.py
	new file:   business_requirement/__openerp__.py
	new file:   business_requirement/data/business_data.xml
	new file:   business_requirement/data/business_sequence.xml
	new file:   business_requirement/models/__init__.py
	new file:   business_requirement/models/business.py
	new file:   business_requirement/security/ir.model.access.csv
	new file:   business_requirement/security/security.xml
	new file:   business_requirement/static/description/icon.png
	new file:   business_requirement/static/img/bus_req.png
	new file:   business_requirement/static/img/bus_req_alias.png
	new file:   business_requirement/static/img/bus_req_approved.png
	new file:   business_requirement/static/img/bus_req_cancel.png
	new file:   business_requirement/static/img/bus_req_confirmed.png
	new file:   business_requirement/static/img/bus_req_cust_story.png
	new file:   business_requirement/static/img/bus_req_done.png
	new file:   business_requirement/static/img/bus_req_drop.png
	new file:   business_requirement/static/img/bus_req_module_diag.png
	new file:   business_requirement/static/img/bus_req_tags.png
	new file:   business_requirement/static/img/bus_req_tags2.png
	new file:   business_requirement/static/img/bus_req_tree.png
	new file:   business_requirement/static/img/module_diag.graphml
	new file:   business_requirement/tests/__init__.py#
	new file:   business_requirement/tests/test_br.py
	new file:   business_requirement/views/business_viw.xml
	new file:   business_requirement/wizards/__init__.py
	new file:   business_requirement/wizards/mail_compose_message.py
@victormmtorres

This comment has been minimized.

Copy link
Author

commented May 27, 2016

This is the new PR which replaces the old one: #127

@coveralls

This comment has been minimized.

Copy link

commented May 27, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 5ea711a on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

@elicoidal

This comment has been minimized.

Copy link

commented May 27, 2016

👍
@dreispt @jbeficent @pedrobaeza @jgrandguillaume
We have cleansed a lot this code based on our usage in the last few month.
We tried to keep all original remarks and discussions since the origin and I think that they should be ready for review and merge.
There are multiple module and this one is the base one: we will add one PR per module.
Honestly, I think it would be better to have a specific repo for the concept as we have already about 10 related modules.

@dreispt

This comment has been minimized.

Copy link
Member

commented May 30, 2016

@elicoidal IMO the topic is different enough to deserve a repo. If we have critical mass for it, sounds good to me.
I can open a discussion about it on the Contributors ML.

@elicoidal

This comment has been minimized.

Copy link

commented May 30, 2016

@dreispt thanks for the feedback.
We have about 10 modules ready and @jbeficent have potential another 3 or 4 based on change requests, parenting management, maybe earned value etc.
A discussion was started some months ago: I can refresh it with a ping and news on the topic

@elicoidal elicoidal referenced this pull request May 30, 2016

Closed

[ADD] gap_analysis #127

@elicoidal

This comment has been minimized.

Copy link

commented May 30, 2016

@dreispt

This comment has been minimized.

Copy link
Member

commented May 30, 2016

I feel that earned value is Project Management and should go here. Change Management too.
Business analysis can sit on top of those feature for an additional layer, adding the detail at the level of requirements/features.

I don't recall the previous discussion right now, you are welcome to revive it.

@elicoidal

This comment has been minimized.

Copy link

commented May 30, 2016

Agree: we will need link modules between them.
Just resent a communication in the community.

@elicoidal

This comment has been minimized.

Copy link

commented May 30, 2016

@victormartinelicocorp Can you make sure to deprecate completely api.one?
@pedrobaeza there are some error due to rst enumerated list in ci but I am not sure this is important. Not sure either how to fix it (in long list the enumerated list are usually restarted at 1.)

@elicoidal

This comment has been minimized.

Copy link

commented May 30, 2016

besides @victormartinelicocorp please check:

business_requirement/init.py:1: [W7902(duplicate-xml-record-id), ] Duplicate xml record id business_requirement.seq_business_requirement.noupdate=1
business_requirement/init.py:1: [W7902(duplicate-xml-record-id), ] Duplicate xml record id business_requirement.seq_type_business_requirement.noupdate=1

@blaggacao

This comment has been minimized.

Copy link

commented May 31, 2016

@elicoidal @victormartinelicocorp Nice! Roughly, what would be the task (areas) to make this v9?

@elicoidal

This comment has been minimized.

Copy link

commented Jun 1, 2016

@blaggacao IMO not much as this is new API.
More is expect for the module business_requirement_project because in v9 projects are not parent/child anymore so this ideally (but not mandatory should be implemented).
Besides there might be many small modifications in the project fields between 8 and 9: I dont think this is so difficult though.
Same would happen with business_requirement_crm: some fields in SQ might have evolved.
Last but not least we rely on pricelists for the estimations: it is possible that that part requires some tweaking.

victor
[FIX] business_requirement: replace deprecated @api.one, duplicate XM…
…L records, rst format file, fix file business_requirement/README.rst, business_requirement/models/business.py
@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 5f9030e on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

victor added some commits Jun 2, 2016

victor
[FIX] business_requirement: Travis Pylint errors, fix file business_r…
…equirement/models/business.py, business_requirement/wizards/mail_compose_message.py
victor
@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 1401460 on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 30e03c0 on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

victor
[FIX] business_requirement: Travis Pylint errors, fix file business_r…
…equirement/models/business.py 2nd try to fix W0105(pointless-string-statement)
@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 656ac99 on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

victor
[FIX] business_requirement: Travis Pylint errors, fix file business_r…
…equirement/README.rst E7901(rst-syntax-error)
@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 7ad75fe on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

victor added some commits Jun 2, 2016

victor
[FIX] business_requirement: Travis Pylint errors, fix file business_r…
…equirement/README.rst 2nd try E7901(rst-syntax-error)
victor
[FIX] business_requirement: Travis Pylint errors, fix file business_r…
…equirement/README.rst 3rd try E7901(rst-syntax-error)
victor
[FIX] business_requirement: Travis Pylint errors, fix file business_r…
…equirement/README.rst 4th try E7901(rst-syntax-error Enumerated list start value not ordinal-1)
@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling ab1a625 on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 557eb35 on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 557eb35 on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

victor
[FIX] business_requirement: Travis Pylint errors, fix file business_r…
…equirement/README.rst E7901(rst-syntax-error Enumerated list start value not ordinal-1)-later-will-check
@victormmtorres

This comment has been minimized.

Copy link
Author

commented Jun 2, 2016

@elicoidal As I show you Travis Fails on this point but IMO should not. Could you check what is wrong with my rst file?:

Start lint check just in modules changed

************* Module business_requirement
business_requirement/init.py:1: [E7901(rst-syntax-error), ] README.rst:7 Enumerated list start value not ordinal-1: "2" (ordinal 2)
business_requirement/init.py:1: [E7901(rst-syntax-error), ] README.rst:7 Enumerated list start value not ordinal-1: "3" (ordinal 3)
business_requirement/init.py:1: [E7901(rst-syntax-error), ] README.rst:7 Enumerated list start value not ordinal-1: "4" (ordinal 4)
business_requirement/init.py:1: [E7901(rst-syntax-error), ] README.rst:7 Enumerated list start value not ordinal-1: "5" (ordinal 5)
business_requirement/init.py:1: [E7901(rst-syntax-error), ] README.rst:7 Enumerated list start value not ordinal-1: "6" (ordinal 6)
pylint expected errors 0, found 1!

@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2016

Coverage Status

Coverage decreased (-2.2%) to 72.748% when pulling 5b5eded on victormartinelicocorp:0_business_requirement_base into f60d9cc on OCA:8.0.

@elicoidal

This comment has been minimized.

Copy link

commented Jun 2, 2016

@victormmtorres

This comment has been minimized.

Copy link
Author

commented Jun 3, 2016

Wrong repository. I will close this PR and place on OCA/business-requirement#2
@elicoidal?

@elicoidal

This comment has been minimized.

Copy link

commented Jun 3, 2016

@elicoidal elicoidal closed this Jun 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.