New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] report_py3o_fusion_server: Add support for PDF Export options of libreoffice #211

Merged
merged 5 commits into from Jul 12, 2018

Conversation

Projects
None yet
3 participants
@elicoidal

Thanks for this!
Mostly details.
I would recommend to bump the version too.
No functional tests

This module was written to let a py3o fusion server handle format conversion instead of local libreoffice.
This module was written to let a py3o fusion server handle format conversion instead of local libreoffice. If you install this module above the *report_py3o* module, you will have to deploy additionnal software components and run 3 daemons (libreoffice, py3o.fusion and py3o.renderserver). This additionnal complexiy comes with several advantages:
* much better performances (libreoffice runs permanently in the background, no need to spawn a new libreoffice instance upon every document conversion).

This comment has been minimized.

@elicoidal
* much better performances (libreoffice runs permanently in the background, no need to spawn a new libreoffice instance upon every document conversion).
* ability to configure PDF export options in Odoo. This will allow you to generate:
* PDF forms

This comment has been minimized.

@elicoidal

elicoidal Apr 25, 2018

add blank line

initial_view = fields.Selection([
('0', 'Page Only'),
('1', 'Bookmarks and Page'),
('2', 'Thumnails and Page'),

This comment has been minimized.

@elicoidal
export_comments = fields.Boolean('Export Comments')
# ExportHiddenSlides (bool) ??
export_hidden_slides = fields.Boolean(
'Export Automatically Insered Blank Pages')

This comment has been minimized.

@elicoidal

elicoidal Apr 25, 2018

"Automatically export Inserted Blank Pages"?

This comment has been minimized.

@alexis-via

alexis-via Apr 25, 2018

I decided to keep the exact label of the Libreoffice interface, so that users can easily find the correspondance between LO and Odoo PDF export options. As you can see in the screenshot avail here https://bitbucket.org/faide/py3o.renderers.juno/issues/1/add-ability-to-set-pdf-export-options this is the exact LO label.

This comment has been minimized.

@elicoidal

elicoidal Apr 25, 2018

strange but 👍 indeed

<group name="general-left" col="1">
<group name="general-image" string="Image">
<field name="image_compression" widget="radio"/>
<label for="image_jpeg_quality" attrs="{'invisible': [('image_compression', '!=', 'jpeg')]}"/>

This comment has been minimized.

@elicoidal

elicoidal Apr 25, 2018

can you improve the format for readability?

@alexis-via

This comment has been minimized.

alexis-via commented Apr 25, 2018

@elicoidal Thanks for your remarks and for spotting the typos ! I took into account most of them in my last commit.

@elicoidal

LGTM.
Is there a way to functional test it?

@alexis-via

This comment has been minimized.

alexis-via commented Apr 25, 2018

@elicoidal As explained on https://bitbucket.org/faide/py3o.renderers.juno/issues/1/add-ability-to-set-pdf-export-options I still have 3 more PRs (out of 5) to do (py3o.fusion, py3o.renderclient and py3o.renderserver) to fully publish my work. I hope to find time tonight to do the 3 remaining PRs. Then you'll be able to setup a py3o environment on an Odoo server for example (but it's not so easy).

@elicoidal

This comment has been minimized.

elicoidal commented Apr 26, 2018

@alexis-via Understood: I will follow up the PR

@lmignon

@alexis-via What a great work! Since this new feature rely on changes into external libs not yet released, I propose to wait for these libs before merging. Do you agree?

@alexis-via

This comment has been minimized.

alexis-via commented May 16, 2018

@lmignon Yes, of course.
The external libs are "ready" to merge, except the PR on py3o.renderers.juno which has a Java compile warning (it works fine, but this java compile warning is annoying). I tried to solve this warning, but without success for the moment... I need help from an experienced Java dev to solve it.

@alexis-via alexis-via force-pushed the akretion:10-py3o-pdf-options branch from 12dc354 to 3438521 Jun 13, 2018

@alexis-via

This comment has been minimized.

alexis-via commented Jul 4, 2018

All the PRs on bitbucket have been merged. So this PR is now ready to be merged.

@alexis-via alexis-via merged commit 8d08bba into OCA:10.0 Jul 12, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/runbot runbot build 3328963-211-343852 (runtime 647s)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment