8.0 runbot website display #101
Conversation
| @@ -9,5 +9,5 @@ class RunbotRepo(models.Model): | |||
|
|
|||
| _order = 'sequence asc' | |||
|
|
|||
| sequence = fields.Integer() | |||
| sequence = fields.Integer(default=0) | |||
There was a problem hiding this comment.
0 is already the default, isn't it?
There was a problem hiding this comment.
not for existing records it seems
There was a problem hiding this comment.
aha, here we go: https://github.com/OCA/OCB/blob/8.0/openerp/models.py#L2394, https://github.com/OCA/OCB/blob/8.0/openerp/fields.py#L425, and there's no "default default" set in the Integer class: https://github.com/OCA/OCB/blob/8.0/openerp/fields.py#L1037
Interesting, so we should always set defaults for integer fields it seems, otherwise we get NULLs in the database on installation, which messes up sorting in this case
There was a problem hiding this comment.
Uhm, that seems something to be patched upstream, don't you think?
There was a problem hiding this comment.
sure, but I'm in the middle of something else right now. If you've some time to spare, go ahead
|
sequence already is in upstream, and we don't need the publishing option any more, so I close this |
small fixes