[7.0] Add module 'customer_credit_limit' #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ credit limit defined in the customer master - Partner's credit (considering total open AR / AP items) - Open order lines (not invoiced) - Open customer invoices + Open customer refunds
| in status draft or sent. | ||
|
|
||
| When approving a Sale Order it computes the sum of: | ||
| * The Accounts Receivable Journal Items pending to be pai |
…lated and used during the credit check.
|
|
||
| <record id="group_so_credit_block_releaser" model="res.groups"> | ||
| <field name="name">Sales Order Credit Block Releaser</field> | ||
| <field name="category_id" ref="base.module_category_sales_management"/> |
There was a problem hiding this comment.
This will break the rendering of the original sales groups in the dropdown. Please give it another category, or (my personal preference) assign the privileges to the sales manager instead of adding a dedicated group for this.
|
cc original authors @jjscarafia, @kittiu (I believe) |
|
You have some flake8 to resolve, and a test fails. Maybe you can set the default limit sufficiently high to make the tests succeed? |
|
Ow, I see this PR is from Dec 2014, not Dec 2015 as I thought ;-( |
|
Closing as stated in #292 as better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reviewed modules 'customer_credit_limit' by Sistemas ADHOC and ECOSOFT and incorporated: