New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] Added the sales_report_product_image module #29
Conversation
# | ||
############################################################################## | ||
|
||
from . import models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line at the end
Thanks for proposing this useful module to OCA. Please rename it to sale_order_product_image to follow naming conventions: area (sale) + object (order) + function (product_image). And please also remove your logo and put OCA generic one or better if you provide an specific one. |
All done! |
Where is runbot? This repo is not integrated with runbot? |
@pedrobaeza , Ready to merge! |
|
||
{ | ||
'name': 'Product image for sale reports', | ||
'author': 'Serpent Consulting Services Pvt. Ltd.,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace \
with '
I have activated runbot for next time you make a commit to build a test instance. @JayVora-SerpentCS, please rename it to the name I have told you (sale_order_..., not sale_report_...). It has more sense, because it also adds the image at sale order form view. |
Updated! |
So finally the web_tree_image is needed? I have added web dependency on runbot and restart it to allow to try the module. I'll tell you when finish |
|
||
{ | ||
'name': 'Product image for sale reports', | ||
'author': 'Serpent Consulting Services Pvt. Ltd.,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't make this line split, use:
'author': 'Serpent Consulting Services Pvt. Ltd., '
'Odoo Community Association (OCA)'
You should provide a README.rst with module description following OCA's template: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst Functionally speaking, I have tried the module on runbot and it works great, but there's some things you can improve:
Thanks anyway for the module! |
@JayVora-SerpentCS Could we consider this as too old and close ? |
No description provided.