Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] sale_order_report_with_note (migrated sale_order_webkit to v8 in qweb and renamed the module) #33

Closed
wants to merge 7 commits into from

Conversation

serpentcs-dev1
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 20, 2016

Coverage Status

Changes Unknown when pulling dfebab3 on darshan-serpent:8.0 into * on OCA:8.0*.

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Changes Unknown when pulling 03d31a9 on darshan-serpent:8.0 into * on OCA:8.0*.

@serpentcs-dev1 serpentcs-dev1 changed the title [IMP] migrated sale_order_webkit to v8 (in qweb) and renamed the module to sale_order_report [ADD] sale_order_report_with_note (migrated sale_order_webkit to v8 in qweb and renamed the module) Aug 29, 2016
@coveralls
Copy link

coveralls commented Aug 29, 2016

Coverage Status

Changes Unknown when pulling 24a24c0 on darshan-serpent:8.0 into * on OCA:8.0*.

Installation
============

No specific installation requirements.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove not used sections.

# Copyright (c) 2011 Camptocamp SA (http://www.camptocamp.com)
# @author Guewen Baconnier
# © 2015 Eficent Business and IT Consulting Services S.L.
# - Jordi Ballester Alomar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line copyrights

@LoisRForgeFlow
Copy link

@darshan-serpent Try to solve your conflicts, to make this mergeable.

README.md Outdated
[![Build Status](https://travis-ci.org/OCA/sale-reporting.svg?branch=8.0)](https://travis-ci.org/OCA/sale-reporting)
[![Coverage Status](https://coveralls.io/repos/OCA/sale-reporting/badge.png?branch=8.0)](https://coveralls.io/r/OCA/sale-reporting?branch=8.0)
[![Build Status](https://travis-ci.org/OCA/sale-reporting.svg?branch=9.0)](https://travis-ci.org/OCA/sale-reporting)
[![Coverage Status](https://coveralls.io/repos/OCA/sale-reporting/badge.png?branch=9.0)](https://coveralls.io/r/OCA/sale-reporting?branch=9.0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you change this to v9? this is still v8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange this is not done in the last commit, not sure when and why it was changed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's weird, it was added in the very first one (dfebab3). Just revert the change ✂️

@rousseldenis
Copy link
Sponsor Contributor

@serpentcs-dev1 Could we consider this as too old and close ? @JayVora-SerpentCS

@JayVora-SerpentCS
Copy link
Sponsor

@serpentcs-dev1 Could we consider this as too old and close ? @JayVora-SerpentCS

Please proceed yes!

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2022
@github-actions github-actions bot closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants