[16.0][MIG] sale_order_invoicing_finished_task: Migration to version 16.0 #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadier-Tecnativa
force-pushed
the
16.0-mig-sale_order_invoicing_finished_task
branch
3 times, most recently
from
896a21c
to
df03fc4
Compare
|
ping @pedrobaeza |
hildickethan
reviewed
Jun 6, 2023
Comment on lines
44
to
45
| if "invoiceable" in vals: | ||
| self.mapped("sale_line_id")._compute_qty_delivered() |
There was a problem hiding this comment.
should this not be added to the depends of said compute? instead of forcing it in the write
Yadier-Tecnativa
force-pushed
the
16.0-mig-sale_order_invoicing_finished_task
branch
4 times, most recently
from
c074e26
to
f6689b8
Compare
* [10.0][ADD] sale_order_invoicing_finished_task: New module * [10.0][IMP] sale_order_invoicing_finished_task: Toggle invoiceable flag in task. * [10.0][FIX] sale_order_invoicing_finished_task: Not invoiceable status * [10.0][IMP] sale_order_invoicing_finished_task: check invoice policy * Add files for README * Update README.rst * Change some format issues in README * Change license to AGPL and improve readme * Update __manifest__.py Add Camptocamp as author * [10.0][FIX] sale_order_invoicing_finished_task: Overwrite create and write methods because the stage_id field onchange not trigger in a form view with statusbar widget * [10.0][IMP] sale_order_invoicing_finished_task: Add tests
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
…e_stock This field is declared in module `sale_stock`, which is not a dependency, but this also makes no sense for tasks to filter on that field.
There were several records with value not totally determined that can cause test to fail on integration test: * No employee linked to the user. * No UoM for service product. * Unknown company timesheet UoM. This commit sets these data for avoiding problems, and also remove a non existing field assignation for removing the warning.
…dated properly in kanban view drag and drop TT27765
Co-Authored-By: Nikul Chaudhary <nikul.chaudhary.serpentcs@gmail.com>
…t instead of task_in_project in tests
Previous parent view doesn't depend on the view that adds the field project_id, so we need to inherit from the proper view. As `sale_timesheet` depends on `sale_project`, no extra dependency needs to be added at manifest level.
hildickethan
approved these changes
Jul 12, 2023
Yadier-Tecnativa
force-pushed
the
16.0-mig-sale_order_invoicing_finished_task
branch
2 times, most recently
from
f8cdbe8
to
1d6d472
Compare
|
ping @chienandalu , @stefan-tecnativa please review. the runboat failed: |
Yadier-Tecnativa
force-pushed
the
16.0-mig-sale_order_invoicing_finished_task
branch
3 times, most recently
from
28f9b3f
to
763ec5d
Compare
Yadier-Tecnativa
force-pushed
the
16.0-mig-sale_order_invoicing_finished_task
branch
from
763ec5d
to
6e12d22
Compare
|
/ocabot migration sale_order_invoicing_finished_task |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at fa0344a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT43245