[11.0][IMP] sale_order_secondary_unit: Add security group #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Apr 15, 2019
| view_product_template = env.ref( | ||
| 'sale_order_secondary_unit.product_template_form_view') | ||
| view_product_template.write({ | ||
| 'groups_id': [(3, group_uom.id)] |
There was a problem hiding this comment.
Isn't enough with putting in the XML groups_id empty?
There was a problem hiding this comment.
I had two options, one is puting in the xml groups_id = [(5,0), (4, ref('new_group'))] and the other in a post_migration remove the old security group. I have chosen the second.
There was a problem hiding this comment.
But this technique on views seems a bit weird, and most being noupdate=0. Even more, groups_id in views doesn't use (4, terminology if I don't remember bad, but directly use the ref of the group.
There was a problem hiding this comment.
Let's continue this way as I'm not sure.
|
How can I restart the CI? |
|
I have forced a rebuild on runbot |
pedrobaeza
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa
This PR depends of OCA/product-attribute#445