[12.0][MIG] sale_manual_delivery #987

AaronHForgeFlow · 2019-11-08T09:05:23Z

Based on #983 + grindtildeath#2 at 8th November

Standard migration. Functional tests done from my side and working fine IMHO. Pending todo:

squash commits
Check if glue module sale_stock_picking_blocking_sale_manual_delivery between this and sale_stock_picking_blocking (proposed in [ADD][10.0] sale_manual_delivery #935) is really needed to be ported to v12. --> not needed

oca-clabot · 2019-11-08T09:05:26Z

Hey @aheficent, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

oleksandrpaziuk o.paziuk@mobilunity.com (no github login found)

Appreciation of efforts,
OCA CLAbot

AaronHForgeFlow · 2019-11-08T09:05:36Z

cc @grindtildeath

stevech091

functional ok

oca-clabot · 2019-12-18T15:11:14Z

Hey @AaronHForgeFlow, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

oleksandrpaziuk o.paziuk@mobilunity.com (no github login found)

Appreciation of efforts,
OCA CLAbot

AaronHForgeFlow · 2019-12-20T12:44:22Z

Added he possibility of changing the route when creating the delivery. This is useful when at the time of creating the order, we don't really know from warehouse and what location we are shipping.

In case no route is provided then the one in the sale order line will be taken.

rousseldenis

Code review

rousseldenis · 2020-01-17T15:51:41Z

@AaronHForgeFlow If ready, could you squash ?

Add base for wizard wizard for manual procurements Update base computation update to OCA guidelines

Add action_manual_procurement_wizard in view

[ADD] Translation and .pot file

[IMP] Update translation files [IMP] lot's of functionnal improvments Don't add already planned or shipped lines in wizard Ensure you have one picking per manual delivery Forbid to add lines or ship more than ordered Planned date is required Improve views, naming and buttons Better Readme Default Carrier set from SO [FIX] Do not add product of type 'service' in manual delivery creation

…om SO Add product name to manual delivery lines

[FIX] call super in case of standard delivery [FIX] when multiple picking candidate available take the right one with date corresponding [FIX] revert of renaming field Add SO line description

[MIG][11] Update Readme + Manifest [MIG][11] Adapt procurement for V11 + rm api.one

Fix view name and improve tests IMP: Use a procurement group according to date planned Fix manifest keys

AaronHForgeFlow · 2020-01-27T11:34:55Z

Hi @leemannd, in the wizard I've seen so far the possibility of changing the carrier and the planned date, but not the delivery address. It is ok to me to add that feature. Could you point me to your repo/the repo where this feature is implemented? Thanks

Also, if I include the delivery_address in the wizard, Would be ok for you to continue with this Pull requests? (same in v10 and v11)

leemannd · 2020-01-27T13:30:50Z

@AaronHForgeFlow Thanks for asking. You have been removing it while helping on the migration of the V11 module -> 1f394eb#diff-ff81e585e998789b0b224c322c8cc742L19

This is present also in the original PR in V10.0 -> https://github.com/OCA/sale-workflow/pull/404/files?file-filters%5B%5D=.xml#diff-ff81e585e998789b0b224c322c8cc742R19

This is for us a blocking point as we have clients using it and needing this possibility.

AaronHForgeFlow · 2020-01-27T14:42:17Z

@leemannd I see. I tried to revert that removal but I missed that part.

I will add it back here, and in v10/v11

leemannd · 2020-01-27T15:38:39Z

@AaronHForgeFlow Just ping me on them, I will update my reviews right away

[IMP]sale_manual_delivery. Specify route at the time of the delivery

…ges.

AaronHForgeFlow · 2020-02-06T16:38:10Z

@leemannd Thanks to @mmequignon we have the delivery address back in the wizard 🎉 It would be nice if you check that everything is as expected.

Thanks.

AaronHForgeFlow · 2020-03-24T07:48:03Z

Applied latest fixes in v11

phuctranfxvn · 2021-01-31T04:32:54Z

sale_manual_delivery/models/stock_move.py

+class StockMove(models.Model):
+    _inherit = "stock.move"
+
+    carrier_id = fields.Many2one("delivery.carrier", string="Delivery Method")


@AaronHForgeFlow, why do we need to define the carrier at the stock.move level ?
cc @i-vyshnevska

It is a requirement of the original authors of the module. #404 (comment)

@AaronHForgeFlow natively Odoo defines the carrier at stock picking level (in delivery module). It confuses us if we have multiple carriers in the same picking (stock.move level), but only one deliver provider defined in picking.

In actual usage, if a picking is delivered by different providers, the picking should be splitted (partial transfer + create back order).

Splits are not performed anymore with this module. In this case two separate manual deliveries will be created.

@i-vyshnevska, do you have any idea?

AaronHForgeFlow · 2021-02-19T15:28:55Z

@rousseldenis is this fine to be merged?

rousseldenis · 2021-02-22T10:28:57Z

/ocabot merge patch

OCA-git-bot · 2021-02-22T10:29:12Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-987-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot · 2021-02-22T11:35:57Z

Congratulations, your PR was merged at 3009c72. Thanks a lot for contributing to OCA. ❤️

AaronHForgeFlow force-pushed the 12.0-mig-sale_manual_delivery branch 2 times, most recently from 651413a to a8bd6da Compare November 8, 2019 09:59

rousseldenis added this to the 12.0 milestone Nov 18, 2019

rousseldenis added the needs review label Nov 18, 2019

AaronHForgeFlow force-pushed the 12.0-mig-sale_manual_delivery branch from a8bd6da to 3ec5837 Compare November 20, 2019 12:25

stevech091 approved these changes Dec 7, 2019

View reviewed changes

AaronHForgeFlow force-pushed the 12.0-mig-sale_manual_delivery branch from 3ec5837 to 765c8a6 Compare December 18, 2019 15:11

OCA-git-bot mentioned this pull request Dec 20, 2019

Migration to version 12.0 #700

Closed

54 tasks

rousseldenis approved these changes Jan 17, 2020

View reviewed changes

OCA-git-bot added the approved label Jan 17, 2020

leemannd and others added 15 commits January 17, 2020 17:07

base module & sales_team

06c08eb

Add base for wizard wizard for manual procurements Update base computation update to OCA guidelines

[MIG][11] Fix tests for V11 stock.picking

bd768b9

[FIX] can switch from manual on sent state + fix field name changed

d356838

Add action_manual_procurement_wizard

b1fd74d

Add action_manual_procurement_wizard in view

flake8 & OCA standards

bda5599

[IMP] report manual procurement on SO from sale team

28c5a3b

[ADD] Translation and .pot file

[TYP] Change manual proc for manual delivery

1b1556e

[ADD] Tests on various use cases

38b3993

Regroup picking per date_planned / carrier + correct wizard action fr…

471078c

…om SO Add product name to manual delivery lines

[FIX] picking split criteria

850b59d

[FIX] call super in case of standard delivery [FIX] when multiple picking candidate available take the right one with date corresponding [FIX] revert of renaming field Add SO line description

add Delivery Address to wizard. by default selec SO partner address.

d8ac037

[MIG][11] rm coding* + python 2to3

3d80018

[MIG][11] Update Readme + Manifest [MIG][11] Adapt procurement for V11 + rm api.one

[MIG][11] Run black to fix lint

cd9c808

Remove unneeded calls to invalidate_cache

51f47fd

Fix view name and improve tests IMP: Use a procurement group according to date planned Fix manifest keys

OCA-git-bot removed the approved label Jan 27, 2020

AaronHForgeFlow force-pushed the 12.0-mig-sale_manual_delivery branch 3 times, most recently from 46d3c5f to 63052bf Compare February 6, 2020 14:47

[MIG]sale_manual_delivery to v12

631f544

[IMP]sale_manual_delivery. Specify route at the time of the delivery

AaronHForgeFlow force-pushed the 12.0-mig-sale_manual_delivery branch from 63052bf to 631f544 Compare February 6, 2020 15:26

AaronHForgeFlow mentioned this pull request Feb 6, 2020

[11.0][MIG] sale_manual_delivery #983

Closed

3 tasks

[FIX] Restore res_partner field in the view with respect to last chan…

2c66950

…ges.

Tonow-c2c added 3 commits March 24, 2020 08:42

[FIX] Partner id will be retrive from wizard to procurement rule

1019421

[FIX] wizard float_compare product precision

c18ac37

[FIX] to use the right product uom rounding

a603ace

phuctranfxvn mentioned this pull request Nov 6, 2020

[13.0] [MIG] sale_manual_delivery #1319

Closed

phuctranfxvn reviewed Jan 31, 2021

View reviewed changes

leemannd approved these changes Feb 1, 2021

View reviewed changes

OCA-git-bot added the approved label Feb 1, 2021

OCA-git-bot added the bot is merging ⏳ label Feb 22, 2021

OCA-git-bot merged commit 5f29a79 into OCA:12.0 Feb 22, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 22, 2021

MiquelRForgeFlow deleted the 12.0-mig-sale_manual_delivery branch February 22, 2021 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] sale_manual_delivery #987

[12.0][MIG] sale_manual_delivery #987

AaronHForgeFlow commented Nov 8, 2019 •

edited

oca-clabot commented Nov 8, 2019

AaronHForgeFlow commented Nov 8, 2019

stevech091 left a comment

oca-clabot commented Dec 18, 2019

AaronHForgeFlow commented Dec 20, 2019

rousseldenis left a comment

rousseldenis commented Jan 17, 2020

AaronHForgeFlow commented Jan 27, 2020

leemannd commented Jan 27, 2020 •

edited

AaronHForgeFlow commented Jan 27, 2020

leemannd commented Jan 27, 2020

AaronHForgeFlow commented Feb 6, 2020

AaronHForgeFlow commented Mar 24, 2020

phuctranfxvn Jan 31, 2021

AaronHForgeFlow Feb 1, 2021

phuctranfxvn Feb 1, 2021

AaronHForgeFlow Feb 1, 2021

phuctranfxvn Feb 1, 2021

AaronHForgeFlow commented Feb 19, 2021

rousseldenis commented Feb 22, 2021

OCA-git-bot commented Feb 22, 2021

OCA-git-bot commented Feb 22, 2021

[12.0][MIG] sale_manual_delivery #987

[12.0][MIG] sale_manual_delivery #987

Conversation

AaronHForgeFlow commented Nov 8, 2019 • edited

oca-clabot commented Nov 8, 2019

AaronHForgeFlow commented Nov 8, 2019

stevech091 left a comment

Choose a reason for hiding this comment

oca-clabot commented Dec 18, 2019

AaronHForgeFlow commented Dec 20, 2019

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis commented Jan 17, 2020

AaronHForgeFlow commented Jan 27, 2020

leemannd commented Jan 27, 2020 • edited

AaronHForgeFlow commented Jan 27, 2020

leemannd commented Jan 27, 2020

AaronHForgeFlow commented Feb 6, 2020

AaronHForgeFlow commented Mar 24, 2020

phuctranfxvn Jan 31, 2021

Choose a reason for hiding this comment

AaronHForgeFlow Feb 1, 2021

Choose a reason for hiding this comment

phuctranfxvn Feb 1, 2021

Choose a reason for hiding this comment

AaronHForgeFlow Feb 1, 2021

Choose a reason for hiding this comment

phuctranfxvn Feb 1, 2021

Choose a reason for hiding this comment

AaronHForgeFlow commented Feb 19, 2021

rousseldenis commented Feb 22, 2021

OCA-git-bot commented Feb 22, 2021

OCA-git-bot commented Feb 22, 2021

AaronHForgeFlow commented Nov 8, 2019 •

edited

leemannd commented Jan 27, 2020 •

edited