Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable_odoo_online: make it clear in README, that feature works in odoo community only #4

Merged
merged 2 commits into from
Apr 9, 2018
Merged

disable_odoo_online: make it clear in README, that feature works in odoo community only #4

merged 2 commits into from
Apr 9, 2018

Conversation

yelizariev
Copy link
Member

No description provided.

Ivan Yelizariev added 2 commits April 9, 2018 06:18
[DOC] disable_odoo_online: clarify docs
95de3a7 
-- one of the features is applied only in odoo community
use newest link
04607c9
pedrobaeza
pedrobaeza requested changes Apr 9, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to change the redaction to:

It must be used only in community version, because ...

@hbrunn
Copy link
Member

hbrunn commented Apr 9, 2018 •
edited
Loading

@pedrobaeza this is exactly not the case. There's code making the override only effctive if the version number doesn't look like enterprise: https://github.com/yelizariev/server-brand/blob/04607c9195451845d996d188dee446ae2afdf223/disable_odoo_online/models/publisher_warranty_contract.py#L13
If you want to be picky, we can say that a breach of contract has nothing to do with legality in the sense of crimes, but well, I don't think we need to argue this point here

@pedrobaeza
Copy link
Member

Ah, OK, I didn't remember that.

@pedrobaeza pedrobaeza merged commit 7009ca8 into OCA:11.0 Apr 9, 2018
eLBati pushed a commit to eLBati/server-brand that referenced this pull request Oct 21, 2018
@eLBati
disable_odoo_online: make it clear in README, that feature works in o…
4045677 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
eLBati pushed a commit to eLBati/server-brand that referenced this pull request Oct 30, 2018
@eLBati
disable_odoo_online: make it clear in README, that feature works in o…
b841487 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
tarteo pushed a commit to tarteo/server-brand that referenced this pull request Dec 6, 2019
@tarteo
disable_odoo_online: make it clear in README, that feature works in o…
3582f48 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
tarteo pushed a commit to tarteo/server-brand that referenced this pull request Dec 6, 2019
@tarteo
disable_odoo_online: make it clear in README, that feature works in o…
4614375 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
mileo pushed a commit to kmee/server-brand that referenced this pull request Mar 31, 2020
@mileo
disable_odoo_online: make it clear in README, that feature works in o…
99a3a7b 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
mileo pushed a commit to kmee/server-brand that referenced this pull request Mar 31, 2020
@mileo
disable_odoo_online: make it clear in README, that feature works in o…
e4e9db8 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
dsolanki-initos pushed a commit to initOS/server-brand that referenced this pull request Oct 21, 2020
@dsolanki-initos
disable_odoo_online: make it clear in README, that feature works in o…
d53724d 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
dsolanki-initos pushed a commit to initOS/server-brand that referenced this pull request Dec 18, 2020
@dsolanki-initos
disable_odoo_online: make it clear in README, that feature works in o…
5d48917 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
vincent-hatakeyama pushed a commit to xcgd/server-brand that referenced this pull request Mar 14, 2022
@vincent-hatakeyama
disable_odoo_online: make it clear in README, that feature works in o…
f79435c 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
remi-filament pushed a commit to lefilament/server-brand that referenced this pull request Feb 8, 2023
@remi-filament
disable_odoo_online: make it clear in README, that feature works in o…
28f76e5 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
remi-filament pushed a commit to lefilament/server-brand that referenced this pull request Feb 8, 2023
@remi-filament
disable_odoo_online: make it clear in README, that feature works in o…
0f97ee1 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
remi-filament pushed a commit to lefilament/server-brand that referenced this pull request Feb 8, 2023
@remi-filament
disable_odoo_online: make it clear in README, that feature works in o…
ef19a77 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
lojanet pushed a commit to lojanet/server-brand that referenced this pull request Nov 17, 2023
@lojanet
disable_odoo_online: make it clear in README, that feature works in o…
943283d 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
OCA-git-bot pushed a commit to lojanet/server-brand that referenced this pull request Jul 19, 2024
@OCA-git-bot
disable_odoo_online: make it clear in README, that feature works in o…
9858c5d 
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn approved these changes

@sebalix sebalix sebalix approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yelizariev @hbrunn @pedrobaeza @sebalix