-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] res_config_settings_enterprise_remove #7
Conversation
The problem with |
@eLBati @pedrobaeza as stated in the description on the readme, this module is not meant to delete the enterprise modules from the modules list. It's only meant to remove them from the config settings view. I would rather create a separate module for that. Or discuss the possibility to modify this module, but in a separate PR. I honestly don't like to introduce warnings in the log when doing an update all. So if it's OK for you, I would keep this PR as it is: a pure porting of the module. |
OK, let's keep this PR as is, but introduce later that. |
Ok |
…ules into a single module.
… to reduce amount of xpath queries.
…o reduce loops, complexity, and eliminate any risky xpath queries.
* [MIG][10.0] Migrate 'res_config_settings_enterprise_remove' * [FIX] Use inherit to override 'res.config.settings'. * [FIX] Remove upgrade_radio widget and group title * [FIX] Improviments in code to remove upgrade fields * [NEW] Remove enterprise upgrade from 'project config settings' * [FIX] Add xpath to remove upgrade fields from 'General Settings'
I made a simple 12.0 migration PR #11 before i noticed this PR. Here is the way to avoid warning messages:
But the name of the module ("res_config_settings_enterprise_remove") can be misleading. Maybe it should be another module named "module_enterprise_remove" ? Or a new module named "enterprise_remove" can be introduced to include both functionalities. I can cancel my PR and/or help with a new PR. Let me know what you think. One last question, why don't we have modules in this repo with auto_install=True? |
@levkar thank you for the tip! I agree with you, an extra module is needed. Or an alternative "enterprise_remove" module would be great, but this solution will prevent the user to install enterprise modules! Both proposals are fine to me. |
Closing in favour of #12 |
#6