[11.0][MIG] dead_mans_switch_client #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] dead_mans_switch_client, dead_mans_switch_server * OCA Transbot updated translations from Transifex * Add demo system parameter and some fixes to README. Fix OCA#314. * Add timeout to urlopen in order to avoid "freeze" of the cron job * Use default timeout in get_param directly * OCA Transbot updated translations from Transifex * [IMP] count all child processes' resources * [FIX] only look at parent if workers are configured * [ADD] tell the server that we don't know a value * [FIX] pass timeout as keyword argument * [ADD] hints for coveralls * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * [ADD] migrate dead_mans_switch_client * [IMP] better readme, s/8.0/9.0/
|
Please check Travis and runbot status |
2 tasks
|
Sorry @pedrobaeza I started with just the patch-commits, so those were destined to fail. I've now migrated the code, so Travis is giving the green light, but Runbot seems to have failed. I was able to open and log into the Runbot, and it seemed to work fine. I wasn't able to download any log files. What can I do to fix the runbot error? |
|
You can check here the logs: https://runbot2.odoo-community.org/runbot/static/build/3327863-1277-e764df/logs/job_20_test_all.txt It's a warning as ir.todo has changed its structure: |
mlaitinen
suggested changes
Jun 5, 2018
- Model ir.cron has changed slightly - urllib2 no longer exists in Python 3 - Strings given to urllib.requests.Request must be encoded as bytes
mlaitinen
force-pushed
the
11.0-mig-dead_mans_switch_client
branch
from
e764dff
to
a748e4a
Compare
mlaitinen
approved these changes
Jun 13, 2018
|
This still seems to be hanging around. Is there anyone who would be willing to be a second reviewer? Does @pedrobaeza know? |
|
OK, let's go for an optimistic merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.