Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][base_exception] Fix union between recordset and parent recordset in base_exception #1602

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
6 participants
@florian-dacosta
Copy link
Contributor

commented Jun 12, 2019

Same as #1601

There is still a bug due to last big refactore on the module.
A test has been added on sale_exception to detect it.

In the code, tested with sale_exception, we try to get the intersection between sale.order.line and sale.order, which obviously fail.

In this PR, we implement a way to manage this properly in submodules.

@hparfr @bealdav @mourad-ehm @sebastienbeau

@florian-dacosta florian-dacosta force-pushed the akretion:12-fix-base-exception-apple-orange branch from 00a8f78 to ad39e06 Jun 12, 2019

@mourad-ehm

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Hi @pedrobaeza, @sebastienbeau , could you merge this PRs. It will fix bug for every one use exception in object an object lien (ex sale and sale line).
Here the related PR
#1601
OCA/sale-workflow#873
OCA/sale-workflow#780
Thanks

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 13, 2019

@pedrobaeza pedrobaeza merged commit 0feb2fd into OCA:12.0 Jun 13, 2019

4 checks passed

ci/runbot runbot build 3374494-1602-ad39e0 (runtime 662s)
Details
codecov/patch 100% of diff hit (target 80.94%)
Details
codecov/project 80.96% (+0.02%) compared to de54298
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.