base_external_dbsource and import_odbc modules adopted for v8.0

[Lauris-v]

Moved both modules out of __unported__ directory and reworked form views for both modules as they were not displayed correctly.
No other changes were made because functions were working as supposed.

[eLBati]

Thanks @Lauris-v
Please also fix the following PEP8 errors so that we get a green build

./import_odbc/import_odbc.py:38:81: E501 line too long (99 > 80 characters)

./import_odbc/import_odbc.py:39:81: E501 line too long (114 > 80 characters)

./import_odbc/import_odbc.py:41:81: E501 line too long (119 > 80 characters)

./import_odbc/import_odbc.py:42:81: E501 line too long (104 > 80 characters)

./import_odbc/import_odbc.py:44:81: E501 line too long (82 > 80 characters)

./import_odbc/import_odbc.py:45:81: E501 line too long (111 > 80 characters)

./import_odbc/import_odbc.py:53:81: E501 line too long (106 > 80 characters)

./import_odbc/import_odbc.py:55:81: E501 line too long (112 > 80 characters)

./import_odbc/import_odbc.py:56:81: E501 line too long (111 > 80 characters)

./import_odbc/import_odbc.py:75:81: E501 line too long (88 > 80 characters)

./import_odbc/import_odbc.py:79:81: E501 line too long (92 > 80 characters)

./import_odbc/import_odbc.py:81:81: E501 line too long (93 > 80 characters)

./import_odbc/import_odbc.py:86:81: E501 line too long (85 > 80 characters)

./import_odbc/import_odbc.py:89:81: E501 line too long (89 > 80 characters)

./import_odbc/import_odbc.py:101:81: E501 line too long (101 > 80 characters)

./import_odbc/import_odbc.py:107:81: E501 line too long (81 > 80 characters)

./import_odbc/import_odbc.py:110:81: E501 line too long (90 > 80 characters)

./import_odbc/import_odbc.py:126:81: E501 line too long (82 > 80 characters)

./import_odbc/import_odbc.py:129:81: E501 line too long (81 > 80 characters)

./import_odbc/import_odbc.py:154:81: E501 line too long (89 > 80 characters)

./import_odbc/import_odbc.py:161:81: E501 line too long (95 > 80 characters)

./import_odbc/import_odbc.py:172:81: E501 line too long (88 > 80 characters)

./import_odbc/import_odbc.py:183:81: E501 line too long (83 > 80 characters)

./import_odbc/import_odbc.py:188:81: E501 line too long (98 > 80 characters)

[gurneyalex]

@Lauris-v have you signed the Contributor License Agreement for OCA? http://odoo-community.org/page/website.cla

[Lauris-v]

@eLBati Fixed PEP8 errors.
@gurneyalex I'm new to all of this and haven't signed that agreement. Is it absolutely neccesary?

[Lauris-v]

And more PEP8 errors, I guess its time I started to study it carefully.

[eLBati]

@Lauris-v locally you can use tools like

• https://pypi.python.org/pypi/pep8
• https://pypi.python.org/pypi/flake8
• https://pypi.python.org/pypi/autopep8/

[Lauris-v]

@eLBati Thanks for info! I already found the Python PEP8 tool and used it to find and correct the style errors. It was good experience for me.

[coveralls]

Coverage remained the same when pulling c61521b on odoo-latvia:8.0 into f2cb9ff on OCA:8.0.

[gurneyalex]

@Lauris-v it is not necessary, especially since this is not a new addon, but it is something nice to do if you intend on participating in the OCA addons effort :-)

[Lauris-v]

@gurneyalex Then I will try to sign and send it.
Guess I'll have to find printer and scanner somewhere :)

[lepistone]

About the CLA, let me expand a bit what @gurneyalex said: the OCA repos should indeed have only contributors that signed the CLA so that the association can defend itself and the modules legally.

For that specific PR, it is a lint change so you are not (yet) marked among the authors, so the CLA is not strictly necessary. But it is still a very good idea.

Thanks @Lauris-v!

[Lauris-v]

@lepistone Thanks for clarification. Now I understand the need of it and I will send it as soon as I get a chance to do so.

[clonedagain]

Can't really make a review, but I just wanted to ask if there are plans to integrate those features into https://github.com/OCA/connector/ ?

[bwrsandman]

👍

[veloutin]

I'm not a fan of using backslashes, when you can use:

help="spam spam spam spam spam"
"and eggs"

[dreispt]

Agree with @veloutin

Also, after a ( you can start a new indented line, instead of aligning the text at the far right. For example:

 'raise_import_errors': fields.boolean(
    'Raise import errors',
    help="Import errors not handled, intended for debugging purposes."
            "\nAlso forces debug messages to be written to the server log."),

[veloutin]

👍

[dreispt]

IMO the code could be nicer using a different indentation strategy, but nevertheless 👍

[bwrsandman]

This PR cannot be merged due to conflicts.

This can be resolved by rebasing with OCA:8.0 using git rebase -i oca/8.0.

[yvaucher]

@Lauris-v Could you rebase it please ?

[max3903]

@Lauris-v ping

[bwrsandman]

Since this PR is accepted but the author hasn't come back with a rebase, I will merge manually. Hopefully the tests will not fail. If they do, I will fix them.