Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD stock_picking_report_by_partner #16

Closed
wants to merge 1 commit into from

Conversation

angelmoya
Copy link
Member

We add new module to asign picking report template to partner, in order to allow set diferents templates for print picking report.

@pedrobaeza
Copy link
Member

Same remarks as in the invoice module. But one thing: are you sure you want to limit the print to one record? Picking waves makes a batch printing for example, or you can select multiple documents to print from list view.

@angelmoya
Copy link
Member Author

This method only is used when click button in form view, like in invoices.

@pedrobaeza
Copy link
Member

OK, I see. But in any case, if someone wants to call it for multiple reports, why limit it? Is there any real reason for that?

=========================

This module was written to extend the functionality of picking reports to support diferent picking report by partner and allow you to set the picking report template in partner form to print this template as default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should note that the template is used only when you are clicking on the print button on the picking form, not when you click on meny Print > Picking List

@angelmoya
Copy link
Member Author

I only could use this method for one report, if I have more than one picking, with more than one partner, with more than one template... then I can't use this method.

Maybe I could set template in one "master" template, in order to print default in other way... Now I'm re-coding this...

@angelmoya
Copy link
Member Author

No, I can't do in other way, if I could have template like invoices I could inherit this to set de partner template, but in picking I think is not a god idea.

Finally I think this is the better way.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.67% when pulling 0ec9261 on AngelMoya-Domatix:stock_picking_report_by_partner into 9ee1b04 on OCA:8.0.

@pedrobaeza
Copy link
Member

OK, thanks for your explanations. Please check travis error.

@max3903 max3903 added this to the 8.0 milestone Feb 27, 2015
{
'name': "Picking Report by Partner",
'version': "1.0",
'author': "Domatix",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Odoo Community Association (OCA) as author ?

@laetitia-gangloff
Copy link

Hello,

I don't understand the position of the field picking_report_id.
Why should have pricelist group to be able to set a picking_report ? (Or I missed something ?)

* go to partner configuration
* set default picking report template
* print picking report

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add 'Try me on Runbot' button and 'Bug Tracker' section?
See https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst as reference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README was updated.

@laetitia-gangloff picking_report_id is after pricelist group, not inside

@laetitia-gangloff
Copy link

Other question, I create a report directly in odoo (qweb view and report) and reference it on a supplier.
Then, I try to print this report an I get an error (QWebTemplateNotFound: External ID not found in the system: stock.report_picking_tst) there is something wrong in my configuration ?

@angelmoya angelmoya force-pushed the stock_picking_report_by_partner branch 2 times, most recently from 8138a36 to 7b2285b Compare September 30, 2015 08:07
@angelmoya
Copy link
Member Author

@laetitia-gangloff sorry I don't know about your error, I was trying on my server with report created on module and works right. I will try it on runbot when starts

@laetitia-gangloff
Copy link

@amoya-dx "picking_report_id is after pricelist group, not inside"

I add screen capture :
Without group "Manage pricelist per supplier"
image

-> no picking_report_id

With group "Manage pricelist per supplier"
image
-> picking_report_id is available

@angelmoya
Copy link
Member Author

Ok, thanks for this capture, I will fix ASAP

@angelmoya angelmoya force-pushed the stock_picking_report_by_partner branch from 7b2285b to 5355f84 Compare September 30, 2015 08:59
@angelmoya
Copy link
Member Author

Fixed the position in the view.

I was testing this error in runbot, this error appear because no external_id found in the template view, I don't know about create report in web client, but if report is in module it's not a problem.

@laetitia-gangloff
Copy link

It seems good now, thank you.
Too bad that is not possible to create report on the fly.

👍

Picking Report by Partner
=========================

This module was written to extend the functionality of picking reports to support diferent picking report by partner and allow you to set the picking report template in partner form to print this template as default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/diferent/different/
s/report/reports/

@gurneyalex
Copy link
Member

small typos in the README; When fixed, I'm 👍

@angelmoya angelmoya force-pushed the stock_picking_report_by_partner branch from 5355f84 to ae2cdb3 Compare September 15, 2016 13:04
@angelmoya
Copy link
Member Author

Sorry for delay, finally it is fixed

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Coverage decreased (-13.8%) to 86.207% when pulling ae2cdb3 on angelmoya:stock_picking_report_by_partner into 11c4fd5 on OCA:8.0.

@pedrobaeza
Copy link
Member

Can you please add tests?

@angelmoya
Copy link
Member Author

Yes, I will do next week

El 16/9/2016 17:29, "Pedro M. Baeza" notifications@github.com escribió:

Can you please add tests?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGcAhW8JuFIewawWKleO3NJeBPZ9bjObks5qqrXagaJpZM4DiwXL
.

@pedrobaeza
Copy link
Member

Closing as no further development. If you want to continue, please reopen it.

@pedrobaeza pedrobaeza closed this Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants