New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD stock_picking_report_by_partner #16
Conversation
Same remarks as in the invoice module. But one thing: are you sure you want to limit the print to one record? Picking waves makes a batch printing for example, or you can select multiple documents to print from list view. |
This method only is used when click button in form view, like in invoices. |
OK, I see. But in any case, if someone wants to call it for multiple reports, why limit it? Is there any real reason for that? |
========================= | ||
|
||
This module was written to extend the functionality of picking reports to support diferent picking report by partner and allow you to set the picking report template in partner form to print this template as default. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should note that the template is used only when you are clicking on the print button on the picking form, not when you click on meny Print > Picking List
I only could use this method for one report, if I have more than one picking, with more than one partner, with more than one template... then I can't use this method. Maybe I could set template in one "master" template, in order to print default in other way... Now I'm re-coding this... |
No, I can't do in other way, if I could have template like invoices I could inherit this to set de partner template, but in picking I think is not a god idea. Finally I think this is the better way. |
OK, thanks for your explanations. Please check travis error. |
{ | ||
'name': "Picking Report by Partner", | ||
'version': "1.0", | ||
'author': "Domatix", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add Odoo Community Association (OCA) as author ?
Hello, I don't understand the position of the field picking_report_id. |
* go to partner configuration | ||
* set default picking report template | ||
* print picking report | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add 'Try me on Runbot' button and 'Bug Tracker' section?
See https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst as reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README was updated.
@laetitia-gangloff picking_report_id is after pricelist group, not inside
Other question, I create a report directly in odoo (qweb view and report) and reference it on a supplier. |
8138a36
to
7b2285b
Compare
@laetitia-gangloff sorry I don't know about your error, I was trying on my server with report created on module and works right. I will try it on runbot when starts |
Ok, thanks for this capture, I will fix ASAP |
7b2285b
to
5355f84
Compare
Fixed the position in the view. I was testing this error in runbot, this error appear because no external_id found in the template view, I don't know about create report in web client, but if report is in module it's not a problem. |
It seems good now, thank you. 👍 |
Picking Report by Partner | ||
========================= | ||
|
||
This module was written to extend the functionality of picking reports to support diferent picking report by partner and allow you to set the picking report template in partner form to print this template as default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/diferent/different/
s/report/reports/
small typos in the README; When fixed, I'm 👍 |
5355f84
to
ae2cdb3
Compare
Sorry for delay, finally it is fixed |
Can you please add tests? |
Yes, I will do next week El 16/9/2016 17:29, "Pedro M. Baeza" notifications@github.com escribió:
|
Closing as no further development. If you want to continue, please reopen it. |
We add new module to asign picking report template to partner, in order to allow set diferents templates for print picking report.