Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [NEW] stock_available_unreserved #206

Merged
merged 1 commit into from Feb 27, 2017

Conversation

JordiBForgeFlow
Copy link
Sponsor Member

Stock Available Unreserved

This module allows users to check the quantity of a stocked product that is
available on-hand, and that has not yet been reserved for use anywhere else.

This key figure is very important during the monitoring of the warehouse
execution, because it assists users to ensure that the flow of products will
not be stuck due to a sudden unavailability of stock.

If the warehouse personnel ensures that the unreserved quantity on hand > 0,
then nobody will be stuck in pickings or manufacturing orders waiting for
the availability of unreserved stock.

@JordiBForgeFlow
Copy link
Sponsor Member Author

cc @sbidoul

@JordiBForgeFlow JordiBForgeFlow added this to the 9.0 milestone Oct 24, 2016
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runbot is not available but tested on local 👍

return domain_quant

@api.multi
def _product_available_not_res_hook(self, quants):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is necessary. The hook is only at the end of the '_product_available' method so we just need to call super to inherit, don't we?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really because you do not have quants when you inherit

@JordiBForgeFlow
Copy link
Sponsor Member Author

Thanks for your feedback @Cedric-Pigeon

@pedrobaeza
Copy link
Member

Can you provide tests?

@JordiBForgeFlow JordiBForgeFlow merged commit d933978 into OCA:9.0 Feb 27, 2017
@rousseldenis
Copy link
Sponsor Contributor

Even if this one was pushed some months ago, maybe more reviews should be preferable. Moreover, one function is not covered by tests.

@JordiBForgeFlow
Copy link
Sponsor Member Author

Thanks @rousseldenis. We will make a separate PR to cover with tests the missing function.
cc @mreficent

@rousseldenis
Copy link
Sponsor Contributor

@jbeficent Otherwise 👍 ;-)

@MiquelRForgeFlow
Copy link
Contributor

@rousseldenis
The method action_open_quants_unreserved() is an action that returns a simple dictionary from product.template. Thus, I think that the method is not necessary to be covered in the test but just tested manually.

StefanRijnhart pushed a commit to StefanRijnhart/stock-logistics-warehouse that referenced this pull request May 15, 2017
* [ADD] new module 'stock_available_unreserved'
gfcapalbo pushed a commit to gfcapalbo/stock-logistics-warehouse that referenced this pull request Jun 29, 2017
* [ADD] new module 'stock_available_unreserved'
@MiquelRForgeFlow MiquelRForgeFlow deleted the 9.0-stock_available_unreserved branch September 6, 2017 10:52
mpanarin pushed a commit to mpanarin/stock-logistics-warehouse that referenced this pull request Feb 13, 2018
* [ADD] new module 'stock_available_unreserved'
mpanarin pushed a commit to mpanarin/stock-logistics-warehouse that referenced this pull request Feb 28, 2018
* [ADD] new module 'stock_available_unreserved'
tschanzt pushed a commit to tschanzt/stock-logistics-warehouse that referenced this pull request Apr 25, 2018
* [ADD] new module 'stock_available_unreserved'
alan196 pushed a commit to Jarsa-dev/stock-logistics-warehouse that referenced this pull request Dec 24, 2018
* [ADD] new module 'stock_available_unreserved'
ougc27 pushed a commit to Jarsa-dev/stock-logistics-warehouse that referenced this pull request Jan 7, 2019
* [ADD] new module 'stock_available_unreserved'
Chandresh-SerpentCS pushed a commit to Chandresh-SerpentCS/stock-logistics-warehouse that referenced this pull request Nov 27, 2019
* [ADD] new module 'stock_available_unreserved'
LoisRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Dec 20, 2019
* [ADD] new module 'stock_available_unreserved'
MateuGForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Feb 25, 2021
* [ADD] new module 'stock_available_unreserved'
sbejaoui pushed a commit to acsone/stock-logistics-warehouse that referenced this pull request Jun 3, 2021
* [ADD] new module 'stock_available_unreserved'
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
* [ADD] new module 'stock_available_unreserved'
Chandresh-SerpentCS pushed a commit to ursais/stock-logistics-warehouse that referenced this pull request Sep 16, 2021
* [ADD] new module 'stock_available_unreserved'
JoanMForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Dec 21, 2021
* [ADD] new module 'stock_available_unreserved'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants