Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] HR Timesheet sheet attendance #169

Merged
merged 7 commits into from
Feb 19, 2019
Merged

[ADD] HR Timesheet sheet attendance #169

merged 7 commits into from
Feb 19, 2019

Conversation

bizzappdev
Copy link
Contributor

Added new module hr_timesheet_sheet_attendance to provide the missing functionality from V9 timesheet module

The module is providing timesheet Sheet integration with attendance.

@bizzappdev
Copy link
Contributor Author

test cases are under development but other than that we can proceed for the code review and functional test.

nikul-serpentcs
nikul-serpentcs reviewed Jan 4, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

hr_timesheet_sheet_attendance/__manifest__.py Show resolved Hide resolved
hr_timesheet_sheet_attendance/models/hr_attendance.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/models/hr_attendance.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/models/hr_timesheet_sheet.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/views/hr_attendance_view.xml Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/views/hr_timesheet_sheet_view.xml Outdated Show resolved Hide resolved
nikul-serpentcs
nikul-serpentcs suggested changes Jan 7, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Change

hr_timesheet_sheet_attendance/tests/__init__.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/tests/test_hr_attendance.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/tests/test_hr_attendance.py Show resolved Hide resolved
hr_timesheet_sheet_attendance/__manifest__.py Show resolved Hide resolved
@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@bizzappdev
Copy link
Contributor Author

test cases are also been added. sorry, forget to mention it before.

@bizzappdev
Copy link
Contributor Author

@nikul-serpentcs changes are done. Can you please review again.
we need another reviewer also if you can ping someone then it would be nice

nikul-serpentcs
nikul-serpentcs approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM 👍

@nikul-serpentcs
Copy link
Member

@nikul-serpentcs changes are done. Can you please review again.
we need another reviewer also if you can ping someone then it would be nice

@pedrobaeza @alexey-pelykh @aheficent Can you please take a look?

AaronHForgeFlow
AaronHForgeFlow reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to not allow to check in / out from timesheet form view? It is shrinking the list of attendances and it does not help much IMO.

@bizzappdev
Copy link
Contributor Author

IMO it is a nice feature that user can manipulate and change/add from timesheet view itself.
since V9 it was also like this.
as far as shrinking the list of attendance is a concern we have only check-in and checkout DateTime field only in that view. still, it is a debatable topic.

@AaronHForgeFlow
Copy link
Contributor

It is more about the alignment. The actions are not aligned to the current status of the attendance. I know it is a minor thing and I am being picky but it'd look better with that, maybe the action could be below the current status.

image

@bizzappdev
Copy link
Contributor Author

indeed it should be aligned. and nice to have an idea about below the Status. we will do the changes

AaronHForgeFlow
AaronHForgeFlow approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks. It works on runbot.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit 8f334fa into OCA:11.0 Feb 19, 2019
naglis pushed a commit to versada/hr-timesheet that referenced this pull request Mar 4, 2019
@bizzappdev
[ADD] HR Timesheet sheet attendance (OCA#169)
a4b9312
bizzappdev added a commit to bizzappdev/timesheet that referenced this pull request Mar 7, 2019
@bizzappdev
[ADD] HR Timesheet sheet attendance (OCA#169)
14b09df
ernestotejeda pushed a commit to Tecnativa/timesheet that referenced this pull request Jan 19, 2022
@bizzappdev
[ADD] HR Timesheet sheet attendance (OCA#169)
4d2acc2
dsolanki-initos pushed a commit to Nitrokey/odoo-timesheet that referenced this pull request Jul 7, 2022
@bizzappdev @dsolanki-initos
[ADD] HR Timesheet sheet attendance (OCA#169)
04745b8
dsolanki-initos pushed a commit to Nitrokey/odoo-timesheet that referenced this pull request Jul 7, 2022
@bizzappdev @dsolanki-initos
[ADD] HR Timesheet sheet attendance (OCA#169)
01a50ca
dsolanki-initos pushed a commit to Nitrokey/odoo-timesheet that referenced this pull request Nov 4, 2022
@bizzappdev @dsolanki-initos
[ADD] HR Timesheet sheet attendance (OCA#169)
1981853
JasminSForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Aug 1, 2023
@bizzappdev @JasminSForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
0bc450e
AaronHForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Oct 5, 2023
@bizzappdev @AaronHForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
aac2358
JasminSForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Oct 6, 2023
@bizzappdev @JasminSForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
7a49cf9
AaronHForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Oct 20, 2023
@bizzappdev @AaronHForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
ca233ea
JasminSForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Oct 27, 2023
@bizzappdev @JasminSForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
cae4d25
JasminSForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Dec 11, 2023
@bizzappdev @JasminSForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
06ca329
LauraCForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Apr 10, 2024
@bizzappdev @LauraCForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
bbbf98a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizzappdevteam bizzappdevteam bizzappdevteam left review comments

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bizzappdev @oca-clabot @nikul-serpentcs @AaronHForgeFlow @OCA-git-bot @bizzappdevteam @pedrobaeza