New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0][FIX] Added translated field Phone/Mail [Needs review] #19

Merged
merged 1 commit into from Jan 8, 2015

Conversation

Projects
None yet
5 participants
@llacroix

llacroix commented Jan 7, 2015

Added translation of some fields in the header. We could technically translate the whole template but it makes more sense to translate some particular fields instead.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 7, 2015

Coverage Status

Coverage remained the same when pulling e0144ce on savoirfairelinux:7.0-Add-translated-fields into cdbb8c4 on OCA:7.0.

coveralls commented Jan 7, 2015

Coverage Status

Coverage remained the same when pulling e0144ce on savoirfairelinux:7.0-Add-translated-fields into cdbb8c4 on OCA:7.0.

@llacroix llacroix changed the title from Added translated field Phone/Mail to [7.0][FIX] Added translated field Phone/Mail [Needs review] Jan 7, 2015

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Jan 7, 2015

Contributor

👍

Contributor

pedrobaeza commented Jan 7, 2015

👍

<td/>
</tr>
<tr>
<td>Mail: ${company.partner_id.email or ''|entity}<br/></td>
<td>${_('Mail:')} ${company.partner_id.email or ''|entity}<br/></td>

This comment has been minimized.

@bwrsandman

bwrsandman Jan 7, 2015

Did you export these translations? I don't see them in the PR.

@bwrsandman

bwrsandman Jan 7, 2015

Did you export these translations? I don't see them in the PR.

This comment has been minimized.

@llacroix

llacroix Jan 7, 2015

I didn't. I'm not sure translations will be used there even if they are exported. The translation happens in the module that uses the mako template. If I export translations, it will export the whole mako which isn't exactly what we'd like.

@llacroix

llacroix Jan 7, 2015

I didn't. I'm not sure translations will be used there even if they are exported. The translation happens in the module that uses the mako template. If I export translations, it will export the whole mako which isn't exactly what we'd like.

@bwrsandman

This comment has been minimized.

Show comment
Hide comment
@bwrsandman

bwrsandman commented Jan 8, 2015

👍

@llacroix

This comment has been minimized.

Show comment
Hide comment
@llacroix

llacroix commented Jan 8, 2015

👍

@foutoucour

This comment has been minimized.

Show comment
Hide comment
@foutoucour

foutoucour commented Jan 8, 2015

👍

pedrobaeza added a commit that referenced this pull request Jan 8, 2015

Merge pull request #19 from savoirfairelinux/7.0-Add-translated-fields
[7.0][FIX] Added translated field Phone/Mail [Needs review]

@pedrobaeza pedrobaeza merged commit 341fbab into OCA:7.0 Jan 8, 2015

2 checks passed

continuous-integration/runbot runbot build 2758910-19-e0144c (runtime 195s)
Details
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment