New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate report_webkit_barcode to 8.0 #29
Conversation
@@ -0,0 +1,25 @@ | |||
# -*- coding: utf-8 -*- | |||
############################################################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use short headers like in https://github.com/OCA/maintainer-tools/blob/master/template/module/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrobaeza this apply to __openerp__.py
too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@pedrobaeza done |
barcode(value, code='Code128', drawOpts=None, htmlAttrs=None) | ||
|
||
Parameters | ||
--------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line should have the same length as the title
👍 |
@pedrobaeza anything else to merge ? |
We need at least 2 more reviewers or 5 days to merge and another reviewer. |
@pedrobaeza maybe OT but would be great add a hook to post a comment in each new PR, there is any integration about this ? |
I don't get you. |
any news about this ? |
👍 |
@ovnicraft we are very scarce on reviewing resources in the OCA. I suggest that for any PR you make you try to review / test a couple of open PR by others. This is the way to helping to get a smoother flow. |
Minimal change in description about filter use to jinja2
${ helper.barcode(value) | safe}