Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate report_webkit_barcode to 8.0 #29

Merged
merged 5 commits into from May 4, 2016
Merged

Migrate report_webkit_barcode to 8.0 #29

merged 5 commits into from May 4, 2016

Conversation

ovnicraft
Copy link
Member

Minimal change in description about filter use to jinja2

${ helper.barcode(value) | safe}

@coveralls
Copy link

Coverage Status

Coverage remained the same at 29.032% when pulling 3cd0777 on ovnicraft:8.0 into f79b739 on OCA:8.0.

@ovnicraft ovnicraft mentioned this pull request Apr 1, 2016
3 tasks
@@ -0,0 +1,25 @@
# -*- coding: utf-8 -*-
##############################################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza this apply to __openerp__.py too ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 29.032% when pulling e6aa69b on ovnicraft:8.0 into f79b739 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 29.032% when pulling 994e54e on ovnicraft:8.0 into f79b739 on OCA:8.0.

@ovnicraft
Copy link
Member Author

@pedrobaeza done

barcode(value, code='Code128', drawOpts=None, htmlAttrs=None)

Parameters
---------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line should have the same length as the title

@coveralls
Copy link

Coverage Status

Coverage remained the same at 29.032% when pulling 2af4a2e on ovnicraft:8.0 into f79b739 on OCA:8.0.

@pedrobaeza
Copy link
Member

👍

@ovnicraft
Copy link
Member Author

@pedrobaeza anything else to merge ?

@pedrobaeza
Copy link
Member

We need at least 2 more reviewers or 5 days to merge and another reviewer.

@ovnicraft
Copy link
Member Author

@pedrobaeza maybe OT but would be great add a hook to post a comment in each new PR, there is any integration about this ?

@pedrobaeza
Copy link
Member

I don't get you.

@ovnicraft
Copy link
Member Author

any news about this ?

@gurneyalex
Copy link
Member

👍

@gurneyalex
Copy link
Member

@ovnicraft we are very scarce on reviewing resources in the OCA. I suggest that for any PR you make you try to review / test a couple of open PR by others. This is the way to helping to get a smoother flow.

@gurneyalex gurneyalex merged commit 4f83804 into OCA:8.0 May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants