10.0 mig website canonical url #344

reinka · 2017-05-23T12:33:15Z

Migration to v10.

Additionally, replaced relative URLs by absolute ones, according to these comments: #299 (review)

oca-clabot · 2017-05-23T12:33:17Z

Hey @reinka, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@reinka (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2017-05-23T12:43:35Z

Isn't there any 9.0 commit to bring? Have you used migration guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0?

reinka · 2017-05-23T12:56:51Z

@pedrobaeza Sorry, but what do you mean by "Isn't there any 9.0 commit to bring?"?

pedrobaeza · 2017-05-23T13:02:34Z

Well, have you run the commands specified in the migration guide? If so, this add any change since the 10.0 branch fork in your PR.

reinka · 2017-05-24T12:00:37Z

@pedrobaeza I'm new to all this. I'll have a look at the requirements in your link and get back to you once I've taken care of it. Please bear with me.

oca-clabot · 2017-05-29T14:55:35Z

Hey @reinka,
We acknowledge that the following users have signed our Contributor License Agreement:

@reinka

Appreciation of efforts,
OCA CLAbot

reinka · 2017-06-07T07:33:02Z

@pedrobaeza I reverted all my commits and proceeded as required in your link. Please let me know if I've mistaken/missed something.

pedrobaeza · 2017-06-07T07:37:37Z

Perfect, now you only need to remove the initial commits + reverts instead of keeping them. If you don't know how, tell me and I'll do it.

reinka · 2017-06-07T10:31:31Z

@pedrobaeza Tried to figure it out myself. I rebased and dropped all the commits you mentioned. Was this the correct way?

pedrobaeza · 2017-06-07T10:53:28Z

Yeah, it seems so!

Now go for the green Travis.

reinka · 2017-06-07T12:25:26Z

@pedrobaeza I'm confused. I've checked the details of the travis build, there it says:

Module website_seo_redirection: 1 failures, 0 errors

It seems all generated errors are due to website_seo_redirection. However, I didn't change anything regarding website_seo_redirection. Am I missing anything?

pedrobaeza · 2017-06-07T12:26:06Z

@yajo can you check about the fail on website_seo_redirection?

yajo · 2017-06-08T10:50:41Z

Maybe you need rebasing?

reinka · 2017-06-16T14:28:50Z

@yajo Sorry to ask, but what kind of rebasing? I rebased before by dropping unnecessary commits.

pedrobaeza · 2017-06-16T14:30:47Z

The main branch is now green, so if you make (assuming origin remote is OCA one):

git fetch origin
git rebase origin/10.0
git push -f

…tics.

Signed-off-by: Jairo Llopis <yajo.sk8@gmail.com>

Upstream website_event_sale addon already implements this behavior, these addons were not installable, thus big happy removal happening.

… the runbot url to 9.0 - remove <data> in the templates - replace <openerp> with <odoo> in the templates

add a proper description correct import according to review

bug fixes + add languages clean the code fix README file

[IMP] add pagination support

[IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.

reinka · 2017-06-16T19:26:36Z

origin remote isn't OCA, since I forked it. I tried to
git remote add upstream https://github.com/OCA/website
git fetch upstream
git rebase upstream/10.0 and finally
git push -f.

That didn't work. After that I ran your commands and it did work. If someone could explain why, I'd really appreciate it.

pedrobaeza · 2017-06-18T14:47:44Z

The rebase hasn't gone correctly.

simahawk · 2018-04-23T07:19:48Z

this and the other duplicated PR #413 are superseeded by #449

yajo added this to the 10.0 milestone May 29, 2017

yajo added the work in progress label May 29, 2017

pedrobaeza mentioned this pull request May 30, 2017

Migration to version 10.0 #262

Closed

35 tasks

reinka force-pushed the 10.0-mig-website_canonical_url branch from 48c1252 to 1d28bd8 Compare June 7, 2017 10:28

reinka force-pushed the 10.0-mig-website_canonical_url branch from 1d28bd8 to 89e8042 Compare June 16, 2017 14:57

rruebner and others added 10 commits June 16, 2017 21:02

[10.0][FIX][website_seo_redirection] Fix url updates in promote panel.

048ce31

Allow carousels and slides to become fluid or not too.

2f761a7

Add debug maps to some files.

f8850f8

Credit creators, using same name across modules to avoid split statis…

32bbec0

…tics.

OCA Transbot updated translations from Transifex

a697fe0

Migrate.

9bbe60a

Signed-off-by: Jairo Llopis <yajo.sk8@gmail.com>

OCA Transbot updated translations from Transifex

4fe3ac9

OCA Transbot updated translations from Transifex

c024f41

[MIG] website_container_fluid: Migration to 10.0

748aa4c

[REM][website_event_register_free[_with_sale]] Not needed

18fac35

Upstream website_event_sale addon already implements this behavior, these addons were not installable, thus big happy removal happening.

yajo and others added 25 commits June 16, 2017 21:02

Add sass and fix website_seo_redirection test.

2927ea9

[MIG][10.0] website_analytics_piwik (OCA#338)

7b096df

Add module website_breadcrumb.

60c75d0

Align breadcrumbs with page layout, putting them inside a container.

ffae955

OCA Transbot updated translations from Transifex

1298c95

Fixes for v9 - increase the version from 8.0.1.0.0 to 9.0.1.0.0 - fix…

f691046

… the runbot url to 9.0 - remove <data> in the templates - replace <openerp> with <odoo> in the templates

Change the license from AGPL to LGPL

37aee11

Update README.rst

20f2986

OCA Transbot updated translations from Transifex

c14a0aa

[MIG] from 9.0 to 10.0 website breadcrumb

4b7f5da

[FIX][website_breadcrumb] Usage instructions

239306c

[UPD] addons table in README.md

06a5f2c

[ADD] setup.py

67cf4cd

OCA Transbot updated translations from Transifex

842117e

[UPD] addons table in README.md

dd8e288

[ADD] setup.py

95a019a

OCA Transbot updated translations from Transifex

a07fbcb

first release of website_canonical_url

970bfc5

add a proper description correct import according to review

FIX the review remarks

f7304ce

bug fixes + add languages clean the code fix README file

remove empty section from README.rst

dee69a2

[IMP] add pagination support

OCA Transbot updated translations from Transifex

38d4b8c

Migrate. Add tests.

ecfc87f

OCA Transbot updated translations from Transifex

df59916

[MIG] website_canonical_url: Migration to 10.0

92afd91

reinka force-pushed the 10.0-mig-website_canonical_url branch from 89e8042 to 92afd91 Compare June 16, 2017 19:03

simahawk closed this Apr 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

10.0 mig website canonical url #344

10.0 mig website canonical url #344

reinka commented May 23, 2017

oca-clabot commented May 23, 2017

pedrobaeza commented May 23, 2017

reinka commented May 23, 2017

pedrobaeza commented May 23, 2017

reinka commented May 24, 2017

oca-clabot commented May 29, 2017

reinka commented Jun 7, 2017

pedrobaeza commented Jun 7, 2017

reinka commented Jun 7, 2017 •

edited

pedrobaeza commented Jun 7, 2017

reinka commented Jun 7, 2017

pedrobaeza commented Jun 7, 2017

yajo commented Jun 8, 2017

reinka commented Jun 16, 2017

pedrobaeza commented Jun 16, 2017 •

edited

reinka commented Jun 16, 2017

pedrobaeza commented Jun 18, 2017

simahawk commented Apr 23, 2018

10.0 mig website canonical url #344

10.0 mig website canonical url #344

Conversation

reinka commented May 23, 2017

oca-clabot commented May 23, 2017

pedrobaeza commented May 23, 2017

reinka commented May 23, 2017

pedrobaeza commented May 23, 2017

reinka commented May 24, 2017

oca-clabot commented May 29, 2017

reinka commented Jun 7, 2017

pedrobaeza commented Jun 7, 2017

reinka commented Jun 7, 2017 • edited

pedrobaeza commented Jun 7, 2017

reinka commented Jun 7, 2017

pedrobaeza commented Jun 7, 2017

yajo commented Jun 8, 2017

reinka commented Jun 16, 2017

pedrobaeza commented Jun 16, 2017 • edited

reinka commented Jun 16, 2017

pedrobaeza commented Jun 18, 2017

simahawk commented Apr 23, 2018

reinka commented Jun 7, 2017 •

edited

pedrobaeza commented Jun 16, 2017 •

edited