From be8c37e1ab757d4abdad6069c7f3e497a3add41a Mon Sep 17 00:00:00 2001 From: Florian Kinder Date: Sat, 31 Jan 2026 16:33:03 +0100 Subject: [PATCH] fix: register storage engines for all CLI convert commands Move engine registration from convertSingleFile() to the start of runConvert(), ensuring engines are available for all convert subcommands including --all, --status, and --set-format. Previously, convertAll() was missing engine registration, causing "unknown storage engine: flatbuffers" errors when using --all --format flatbuffers. --- cmd/ocap-webserver/main.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/ocap-webserver/main.go b/cmd/ocap-webserver/main.go index 11346e1a..cdbd22e5 100644 --- a/cmd/ocap-webserver/main.go +++ b/cmd/ocap-webserver/main.go @@ -71,6 +71,10 @@ func runConvert(args []string) error { ctx := context.Background() + // Register storage engines for CLI commands that read data directly + storage.RegisterEngine(storage.NewProtobufEngine(setting.Data)) + storage.RegisterEngine(storage.NewFlatBuffersEngine(setting.Data)) + switch { case *status: return showConversionStatus(ctx, repo) @@ -125,10 +129,6 @@ func convertSingleFile(ctx context.Context, repo *server.RepoOperation, inputFil baseName = baseName[:len(baseName)-len(ext)] } - // Register engines - storage.RegisterEngine(storage.NewProtobufEngine(dataDir)) - storage.RegisterEngine(storage.NewFlatBuffersEngine(dataDir)) - // Check if operation exists in database - if so, use worker for consistent behavior if op, err := repo.GetByFilename(ctx, baseName); err == nil && op != nil { log.Printf("Converting operation %d: %s (format: %s)", op.ID, op.Filename, format)