Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that id must be consistent across all versions #542

Closed
zimeon opened this issue Apr 26, 2021 · 2 comments · Fixed by #568
Closed

Clarify that id must be consistent across all versions #542

zimeon opened this issue Apr 26, 2021 · 2 comments · Fixed by #568
Assignees
Labels
Editorial Editorial issues (no changes to intent) OCFL Object Ready for Review Ready for review by editorial group
Milestone

Comments

@zimeon
Copy link
Contributor

zimeon commented Apr 26, 2021

@awoods comment in OCFL/fixtures#87:

Should we add text around https://ocfl.io/draft/spec/#E037 along the lines of: This must be set in the first version of the object, must be unique in the local context, and must not change between versions of the same object.?

@zimeon zimeon added Editorial Editorial issues (no changes to intent) OCFL Object labels Apr 26, 2021
@zimeon zimeon added this to the 1.1 milestone Apr 26, 2021
@zimeon
Copy link
Contributor Author

zimeon commented Apr 26, 2021

I like the idea of clarifying the text that the id must be consistent across all versions. I don't think we should define it in terms of the first version however, because the v1 inventory may or may not stored and, for the case that all inventories are stored, I think typical validation strategy will be to start with the root/latest inventory and work backwards to check consistency

@awoods
Copy link
Member

awoods commented May 23, 2021

Updated wording (around https://ocfl.io/draft/spec/#E037) focused on consistency of object id across all "inventory.json" files at the object root and within version directories:

This must be unique in the local context and must not change between versions of the same object.

@awoods awoods added the Ready for Review Ready for review by editorial group label May 23, 2021
@rosy1280 rosy1280 self-assigned this Aug 24, 2021
rosy1280 added a commit that referenced this issue Oct 19, 2021
zimeon pushed a commit that referenced this issue Oct 25, 2021
* update id language

fixes #542

* Update index.html

whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial Editorial issues (no changes to intent) OCFL Object Ready for Review Ready for review by editorial group
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants