🔥 require python >= 3.7 #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .circleci/config.yml
|
GH already tells me that on their side (GH Actions), the ubuntu:18.04 base image is deprecated now. I don't know about Circle CI. But we do have the problem that most of our So I guess I am saying we should also upgrade the base image now. Surprising myself there, but my guess is the other way is more painful overall. |
bertsky
approved these changes
Nov 30, 2022
Agreed, let's make the jump now. I'll adapt. |
bertsky
approved these changes
Jan 16, 2023
stweil
reviewed
Jan 18, 2023
stweil
reviewed
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Dockerfile, install python3.7 from the deadsnakes PPA instead of the 18.04 standard python3.6 and stop testing for python3.6.
With the updated base image, we can then tackle the update in ocrd_all.