Skip to content
Browse files

change to Jane Street functor application indentation in one case

  • Loading branch information...
1 parent fab6277 commit 2fcdd2f116457c0e9c354aae713f8105cb976830 @pszilagyi pszilagyi committed Mar 22, 2013
View
42 tests/failing-output/js-functor.ml
@@ -0,0 +1,42 @@
+module M =
+ Foo (G)
+ (H)
+
+module M =
+ Foo
+ (G)
+ (struct
+ let x
+ end)
+ (H)
+
+(* CR pszilagyi: To me, this looks fine as it is. The rule seems fine as "indent
+ arguments by 2". To illustrate, with a case where the functor name is longer: *)
+module M =
+ Functor (G)
+ (H)
+ (I)
+
+
+
+(* sweeks *)
+
+include Foo (struct
+ let x
+ end) (struct
+ let y
+ end)
+
+include
+ Foo (struct
+ let x
+ end) (struct
+ let y
+ end)
+
+module M =
+ Foo (struct
+ let x
+ end) (struct
+ let y
+ end)
View
42 tests/failing/js-functor.ml
@@ -0,0 +1,42 @@
+module M =
+ Foo (G)
+ (H)
+
+module M =
+ Foo
+ (G)
+ (struct
+ let x
+ end)
+ (H)
+
+(* CR pszilagyi: To me, this looks fine as it is. The rule seems fine as "indent
+ arguments by 2". To illustrate, with a case where the functor name is longer: *)
+module M =
+ Functor (G)
+ (H)
+ (I)
+
+
+
+(* sweeks *)
+
+include Foo (struct
+ let x
+ end) (struct
+ let y
+ end)
+
+include
+ Foo (struct
+ let x
+ end) (struct
+ let y
+ end)
+
+module M =
+ Foo (struct
+ let x
+ end) (struct
+ let y
+ end)
View
0 tests/passing/js-functor.ml.opts → tests/failing/js-functor.ml.opts
File renamed without changes.
View
22 tests/passing/js-functor.ml
@@ -1,22 +0,0 @@
-module M =
- F (G)
- (H) (* OK, line up the functor args *)
-
-module M =
- F
- (G)
- (H)
-
-(* CR pszilagyi: To me, this looks fine as it is. The rule seems fine as "indent
- arguments by 2". To illustrate, with a case where the functor name is longer: *)
-module M =
- Functor (G)
- (H)
- (I)
-
-(* CR pszilagyi: That is pretty awful. We really want this? Let's at least discourage
- the F style for multi-argument functors? *)
-include F(struct
- let blah _
- end)
- (G)

0 comments on commit 2fcdd2f

Please sign in to comment.
Something went wrong with that request. Please try again.