Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add minimal documentation for solving system and retrieving results #16

Merged
merged 1 commit into from Mar 16, 2023

Conversation

edwintorok
Copy link
Contributor

This can be inferred from tests/*.ml, but it is better to have some minimal documentation on what the parameters mean.

Especially that solving the system returns the same type that was given as input (i.e. the environment is mutable).

This is my attempt to improve the documentation slightly based on what I could infer from the tests, please correct me if it is wrong or note entirely accurate.

This can be inferred from tests/*.ml, but it is better to have some
minimal documentation on what the parameters mean.

Especially that solving the system returns the same type that was given
as input (i.e. the environment is mutable).

Signed-off-by: Edwin Török <edwin@etorok.net>
Copy link
Contributor

@hra687261 hra687261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM.

Documenting the library and improving is on our TODO list although we're short on time to address it sooner.
Feel free to open issues and report any problems you might encounter or features you wish to see in it.

@hra687261 hra687261 merged commit df00c52 into OCamlPro:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants