Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol] StoreGeneratedPattern should not appear for Identity #116

Closed
karataliu opened this issue Jul 17, 2015 · 2 comments
Closed

[Protocol] StoreGeneratedPattern should not appear for Identity #116

karataliu opened this issue Jul 17, 2015 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@karataliu
Copy link
Contributor

@karataliu karataliu commented Jul 17, 2015

ModuleProducer.cs:

   MetadataProperty storeGeneratedPattern = null;
                    efProperty.MetadataProperties.TryGetValue(
                        AnnotationSchema + ":StoreGeneratedPattern",
                        true,
                        out storeGeneratedPattern);

                    if (storeGeneratedPattern != null)
                    {
                        SetComputedAnnotation(model, property);
                    }

This would generate StoreGeneratedPattern even the value is Identity.

Should verifiy the value is Computed when setting such pattern.

@karataliu karataliu added P1 labels Jul 17, 2015
@karataliu karataliu added this to the v0.3.0-beta2 milestone Jul 30, 2015
@karataliu
Copy link
Contributor Author

@karataliu karataliu commented Jul 30, 2015

<Term Type="Core.Tag" Name="Computed" AppliesTo="Property" DefaultValue="true">
<Annotation Term="Core.Description" String="A value for this property is generated on both insert and update"/>
</Term>

https://msdn.microsoft.com/en-us/library/system.data.metadata.edm.storegeneratedpattern(v=vs.110).aspx

@lewischeng-ms
Copy link
Contributor

@lewischeng-ms lewischeng-ms commented Jul 31, 2015

Resolved in #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.