New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed error information for exceptions #24

Closed
karataliu opened this Issue Feb 28, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@karataliu
Contributor

karataliu commented Feb 28, 2015

In some places the code just throw exception without error message. We'd better add detailed information for those error messages.

@karataliu karataliu added the todo label Feb 28, 2015

@karataliu karataliu changed the title from Add detailed error messages to Add detailed error information for exceptions Feb 28, 2015

@congysu congysu added this to the v0.3 milestone Jul 17, 2015

@lewischeng-ms

This comment has been minimized.

Contributor

lewischeng-ms commented Aug 12, 2015

We should unify the exception in RESTier. That is to say if LINQ expression or EF throws an exception. RESTier should wrap it and throw proper exception or return correct status code instead of just leaking the exception to end user.

As an example, #47 shows a duration-related exception thrown by EF. In this case, we should catch it and return 4XX bad request instead of return 500 internal server error. This is a client request problem not service issue.

@lewischeng-ms

This comment has been minimized.

Contributor

lewischeng-ms commented Oct 8, 2015

Part of the work mentioned is already done by ec3dc8a

@lewischeng-ms

This comment has been minimized.

Contributor

lewischeng-ms commented Oct 13, 2015

Related pull request #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment