New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EF7 ChangeSetPreparer.PrepareAsync is using the wrong ApiContext Property #254

Merged
merged 1 commit into from Nov 9, 2015

Conversation

Projects
None yet
3 participants
@eerhardt
Contributor

eerhardt commented Nov 6, 2015

EF7 ChangeSetPreparer.PrepareAsync is using the wrong ApiContext.GetProperty name to find the current DbContext. It is currently hard-coded to "DbContext", when it should be using the DbApiConstants.DbContextKey constant.

This causes a NullReferenceException during change set submission because it can't find the dbContext.

EF7 ChangeSetPreparer.PrepareAsync is using the wrong ApiContext.GetP…
…roperty name to find the current DbContext. It is currently hard-coded to "DbContext", when it should be using the DbApiConstants.DbContextKey constant.
@msftclas

This comment has been minimized.

msftclas commented Nov 6, 2015

Hi @eerhardt, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Eric Erhardt). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@lewischeng-ms lewischeng-ms merged commit e4f7041 into OData:master Nov 9, 2015

@lewischeng-ms lewischeng-ms added this to the 0.4.0 milestone Nov 9, 2015

@lewischeng-ms lewischeng-ms self-assigned this Nov 9, 2015

@lewischeng-ms

This comment has been minimized.

Contributor

lewischeng-ms commented Nov 9, 2015

@eerhardt Merged. Thanks for fixing the issue.

@eerhardt eerhardt deleted the eerhardt:upstreammaster branch Nov 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment