Add DateTime/Date/TimeOfDay support. Simplify EF7 entity update logic. #278
Conversation
| return EdmCoreModel.Instance.GetDate(efProperty.Nullable); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Is your code written specially for EF7 here? I am not sure about the difference that in my code the DB type name comes from the ColumnAttribute. But I guess we can keep both code here and use a compilation constant to differentiate EF6 and EF7?
There was a problem hiding this comment.
No this works only for EF6, EF7 has a much cleaner approach.
EF7 shares most code files from EF6, but has dedicated ModelProducer and ChangeSetPreparer.
…tPreparer.SetValue. Tabs to spaces.
|
Hi Lewis, perhaps I'd better remove all EF6 changes to make your merge easier? Or you can check in first and let me merge. |
|
@rayao, my PR need to be based on yours and use some code you wrote. So please address the comments and merge this PR first if all tests can pass and there is no code analysis issue during compilation. Thanks! |
…pass. Spell correction.
Add DateTime/Date/TimeOfDay support. Simplify EF7 entity update logic. Borrowed Northwind DB config changes from Lewis's PR, to make baseline test pass.
|
Sorry I messed up the branch hierarchy. Didn't notice there're check-ins before merge. Since it tells me "no conflict", I took that for "no change since last sync". |
|
@rayao Don't worry about that. You didn't mess up the master branch history. It's OK to merge a pull request like this. For future, if you want to make the commits a single line, you can first do a |
#273
Also, removed EF.SqlServer dependency from Restier.EF7