New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.FX.DI integration [Option 2] #286

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@rayao
Contributor

rayao commented Jan 31, 2016

Use Micorsoft DI framework to replace current Dictionary<,> based service registration.
This is basically identical to my previous #264. Compared to option 1 #285, this is a relatively conservative change. It's up to you to make a choice.
In this change ApiConfiguration has its service registration/resolve built upon MS.FX.DI, almost all public interfaces remain same.
There's 1 major breaking change:
Services or hook handlers can't be resolved before ApiConfiguraion committed.

Personally I like option 1 more, IMO it's cleaner, more componentized, and the building pattern mimics what's in ASP.NET MVC.

@rayao rayao added cla-not-required and removed cla-required labels Jan 31, 2016

@rayao rayao closed this Feb 17, 2016

@rayao rayao deleted the rayao:DI2 branch Feb 17, 2016

@rayao

This comment has been minimized.

Contributor

rayao commented Feb 17, 2016

Go with option 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment