Fix various design issues in RESTier #313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return result; | ||
| } | ||
| } | ||
|
|
||
| if (context.ModelReference == null) | ||
| { | ||
| return null; |
There was a problem hiding this comment.
Maybe every return null should be return CallInner()
There was a problem hiding this comment.
Yeah, you are right. It MAY have inner expander from the provider to call. Thanks for the reminder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lewischeng-ms@6256eaf resolves #308.
lewischeng-ms@654ac34 resolves #309.
lewischeng-ms@fec87c9 resolves #310.
lewischeng-ms@ad2d882 resolves #311.
lewischeng-ms@d326e78 resolves #312.