Make a truly async model pipeline work for WebApi publisher. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| batchHandler.ApiFactory = apiFactory; | ||
| } | ||
| var pathHandler = new DefaultODataPathHandler(); | ||
| ////defaultODataPathHandler.ResolverSetttings = config.GetResolverSettings(); |
There was a problem hiding this comment.
ResolverSettings is an internal member, must find a way to set it if no other convenient API.
|
I'm not quite sure if we should go this way. Another option is to force the model pipeline synchronous. |
|
@rayao, based on our offline discussion, please change the PR accordingly and merge. Thanks！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A truly async model pipeline leads to unsuccessful routing registration. We didn't see this in our existing samples because their model pipelines are synchronous in nature.
This change tries to defer the actual RESTier routing setup until the model pipeline returns. Before that, requests run on a placeholder routing.