Derivedtype support (part 2) #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chinadragon0515, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
chinadragon0515
force-pushed
the
derivedtype
branch
5 times, most recently
from
8073a46 to
11c4798
Compare
chinadragon0515
force-pushed
the
derivedtype
branch
2 times, most recently
from
3721964 to
702d1aa
Compare
chinadragon0515
force-pushed
the
derivedtype
branch
from
702d1aa to
c69ac00
Compare
| if (sourceType == resultType) | ||
| { | ||
| return new DerivedDataReference(source); | ||
| return new QueryModelReference(source.EntitySet,source.Type); |
|
All comments are addressed in next PR, will merge this PR first, and more comments, continue add here, I will address in next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes part of issue #117
Description
Add support for the query
Checklist (Uncheck if it is not completed)