Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivedtype support (part 2) #410

Merged
merged 5 commits into from May 27, 2016

Conversation

chinadragon0515
Copy link
Contributor

Issues

This pull request fixes part of issue #117

Description

Add support for the query

Checklist (Uncheck if it is not completed)

  • [ x ] Test cases added
  • [ x ] Build and test with one-click build and test script passed

@msftclas
Copy link

Hi @chinadragon0515, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Dashuang He). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@chinadragon0515 chinadragon0515 force-pushed the derivedtype branch 2 times, most recently from 3721964 to 702d1aa Compare May 27, 2016 00:37
if (sourceType == resultType)
{
return new DerivedDataReference(source);
return new QueryModelReference(source.EntitySet,source.Type);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after comma

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@chinadragon0515
Copy link
Contributor Author

All comments are addressed in next PR, will merge this PR first, and more comments, continue add here, I will address in next PR.

@chinadragon0515 chinadragon0515 merged commit c69ac00 into OData:master May 27, 2016
@chinadragon0515 chinadragon0515 deleted the derivedtype branch May 30, 2016 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants