Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp solution for URI with backslash and slash #422

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

chinadragon0515
Copy link
Contributor

@chinadragon0515 chinadragon0515 commented Jun 6, 2016

Issues

*This pull request fixes issue #415 and it is a temp solution for #414

Description

Make URL can parse slash or backslash in key of entity

Checklist (Uncheck if it is not completed)

  • [ x ] Test cases added
  • [ x ] Build and test with one-click build and test script passed

Additional work necessary

This is a temp solution, need to revisit when key as alias is supported by ODL, and this is tracked with #421

var handler = api.Context.GetApiService<IODataPathHandler>();
if (handler == null)
{
handler = new DefaultODataPathHandler();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to register the default type DefaultODataPathHandler to the container.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, we keep as it is now.

@lewischeng-ms
Copy link
Contributor

LGTM otherwise.

@chinadragon0515 chinadragon0515 merged commit 589bb5a into OData:master Jun 8, 2016
@chinadragon0515 chinadragon0515 deleted the path branch June 24, 2016 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants