Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp solution for URI with backslash and slash #422

Merged
merged 1 commit into from Jun 8, 2016

Conversation

@chinadragon0515
Copy link
Contributor

@chinadragon0515 chinadragon0515 commented Jun 6, 2016

Issues

*This pull request fixes issue #415 and it is a temp solution for #414

Description

Make URL can parse slash or backslash in key of entity

Checklist (Uncheck if it is not completed)

  • [ x ] Test cases added
  • [ x ] Build and test with one-click build and test script passed

Additional work necessary

This is a temp solution, need to revisit when key as alias is supported by ODL, and this is tracked with #421

@chinadragon0515 chinadragon0515 force-pushed the chinadragon0515:path branch from 00a3252 to 589bb5a Jun 6, 2016
var handler = api.Context.GetApiService<IODataPathHandler>();
if (handler == null)
{
handler = new DefaultODataPathHandler();

This comment has been minimized.

@lewischeng-ms

lewischeng-ms Jun 7, 2016
Contributor

It's better to register the default type DefaultODataPathHandler to the container.

This comment has been minimized.

@chinadragon0515

chinadragon0515 Jun 7, 2016
Author Contributor

Per discussion, we keep as it is now.

@lewischeng-ms
Copy link
Contributor

@lewischeng-ms lewischeng-ms commented Jun 7, 2016

LGTM otherwise.

@chinadragon0515 chinadragon0515 merged commit 589bb5a into OData:master Jun 8, 2016
@chinadragon0515 chinadragon0515 deleted the chinadragon0515:path branch Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants