Add Etag support #458
Merged
Add Etag support #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinadragon0515
force-pushed
the
etag
branch
2 times, most recently
from
b4a7517 to
e486965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
*This pull request fixes issue #22 and #38
Description
For the support,
When an entity type whose has some properties with ConcurrencyCheck attribute, during get request, either single result or collection result, each return result will have "@odata.etag" annotation.
When request return a single entity and this setting is added "configuration.MessageHandlers.Add(new ETagMessageHandler());", the response Header will have Etag Header beside the "@odata.etag" annotation in response body.
During CRUD, If-Match and If-None-Match are checked.
If an item required etag, but during update/delete request, there is no If-Match or If-None-Match tag, should return 428 (precondition required).
Items not covered by above issue and need to be covered by this issue,
#114
Checklist (Uncheck if it is not completed)
Additional work necessary
Need document update on how to use EtagMessageHandler.