Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always get parameter alias from ParameterAliasNodes by odl parser #143

Closed
LianwMS opened this issue Jan 12, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@LianwMS
Copy link
Contributor

commented Jan 12, 2015

In DefaultODataPathHandler, if unresolved path segment is encountered, we
can't get parameter alias from odl parser.
So we get the parameter alias info from the query string in this case.
The bug is fixed in ODL 6.5.
We can always get the parameter alias from odl parser after migration to ODL
6.5 or later,
and we don't need query string in DefaultODataPathHandler and
ODataPathSegmentTranslator any more.

Work Item Details

Original CodePlex Issue: Issue 2093
Status: Proposed
Reason Closed: Unassigned
Assigned to: Unassigned
Reported on: Aug 5, 2014 at 6:13 AM
Reported by: fenzhao
Updated on: Dec 10, 2014 at 12:31 AM
Updated by: yishaigalatzer

@LianwMS

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2015

On 2014-08-05 13:19:06 UTC, jinfutan commented:

The fix can start from change:
return ODataPathSegmentTranslator.TranslateODLPathToWebAPIPath(
path,
model,
unresolvedPathSegment,
id,
enableUriTemplateParsing,
unresolvedPathSegment == null ?
uriParser.ParameterAliasNodes :
// We can't get parameter alias if ODataUnrecognizedPathException was thrown.
new Dictionary<string, Semantic.SingleValueNode>(),
unresolvedPathSegment == null ? null : queryString);

To
return ODataPathSegmentTranslator.TranslateODLPathToWebAPIPath(
path,
model,
unresolvedPathSegment,
id,
enableUriTemplateParsing,
uriParser.ParameterAliasNodes ,
null);

And then check if there is other related change.

@LianwMS

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2015

On 2014-08-05 14:04:48 UTC, fenzhao commented:

The last parameter "queryString" is also useless after the change. Please remove

@LianwMS LianwMS added this to the v5.4 Beta milestone Jan 12, 2015

@LianwMS LianwMS added bug low labels Jan 12, 2015

@LianwMS LianwMS modified the milestones: v5.4 Beta, 5.4 Jan 12, 2015

@congysu congysu modified the milestones: V5.5, V5.4 Beta Jan 23, 2015

@xuzhg xuzhg assigned challenh and unassigned xuzhg Jan 27, 2015

@congysu congysu modified the milestones: V5.4.1, V5.4 Feb 6, 2015

@challenh challenh added the Resolved label Mar 2, 2015

@challenh

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2015

fixed by 13608a0

@challenh challenh closed this Mar 2, 2015

@congysu congysu modified the milestones: V5.5, V5.4.1 Apr 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.