Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #304 Support setting namespaces for operations #444

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@VikingsFan
Copy link
Contributor

commented Jul 23, 2015

No description provided.

}

/// <summary>
/// The Namespace by default is the ModelBuilder's Namespace.
/// </summary>
public string Namespace { get; set; }

This comment has been minimized.

Copy link
@xuzhg

xuzhg Jul 23, 2015

Member

how about if customer sets the namespace as empty or null?

@xuzhg

This comment has been minimized.

Copy link
Member

commented Jul 23, 2015

Others look good to me. Thanks.

@VikingsFan VikingsFan force-pushed the VikingsFan:Issue304 branch from 7ddf254 to 7c5168b Jul 23, 2015

@VikingsFan

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2015

Checked in 483ce56

@VikingsFan VikingsFan closed this Jul 23, 2015

@@ -25,6 +26,7 @@ internal ProcedureConfiguration(ODataModelBuilder builder, string name)
{
Name = name;
ModelBuilder = builder;
_namespace = null;

This comment has been minimized.

Copy link
@congysu

congysu Jul 24, 2015

Contributor

Remove this line. _namespace initializes to null by default.

/// <summary>
/// The Namespace by default is the ModelBuilder's Namespace.
/// </summary>
public string Namespace

This comment has been minimized.

Copy link
@congysu

congysu Jul 24, 2015

Contributor

Add this to public API review.

@congysu

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2015

@vojtechvit @brjohnstmsft Can you help review the change? Thanks.

// Act
var response = client.GetAsync("http://localhost/$metadata").Result;
var responseString = response.Content.ReadAsStringAsync().Result;

This comment has been minimized.

Copy link
@congysu

congysu Jul 24, 2015

Contributor

// Assert

[Theory]
[InlineData("Vehicles(Model=8,Name='8')/System.Web.OData.Builder.TestModels.Car/customize.NSAction")]
[InlineData("MyVehicle/System.Web.OData.Builder.TestModels.Car/customize.NSAction")]
public void Can_find_customized_namespace_action(string url)

This comment has been minimized.

Copy link
@congysu

congysu Jul 24, 2015

Contributor

Capitalize Each Word.

@congysu congysu added this to the v5.7 milestone Jul 24, 2015

@vojtechvit

This comment has been minimized.

Copy link

commented Jul 24, 2015

looks good!

@@ -917,6 +917,21 @@ public void ServiceDocument_OnlyContainOneFunctonImport_ForOverloadFunctions()
}

[Fact]
public void ServiceDocument_FunctionNamesapce_Configuration()

This comment has been minimized.

Copy link
@brjohnstmsft

brjohnstmsft Jul 24, 2015

Contributor

FunctionNamespace (spelling)

@brjohnstmsft

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2015

Changes look good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.