Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking propetry for null changed from Or to OrElse #453

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@Ilchert
Copy link
Contributor

commented Jul 30, 2015

Checking propetry for null chanaged from "($it.Property == null) | false" (bitwise OR) to "($it.Property == null) || false" (logical OR).

Checked propetry for null chanaged from "($it.Property == null) | fal…
…se" (conditional OR) to "($it.Property == null) || false" (logical OR).
@msftclas

This comment has been minimized.

Copy link

commented Jul 30, 2015

Hi @Ilchert, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@@ -1779,7 +1779,7 @@ private static Expression CheckIfArgumentsAreNull(Expression[] arguments)
if (arguments.Any())

This comment has been minimized.

Copy link
@VikingsFan

VikingsFan Jul 31, 2015

Contributor

Please add/modify unit test for FilterBinder's change in FilterBinderTest, make sure all unit test is pass.
FYI http://odata.github.io/WebApi/#09-01-unittest-e2etest

@Ilchert

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2015

I added Unit test.

@VikingsFan

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2015

Thanks for your contribution! Merged 35b7f5c & 2bcbe4c

Please refine unit test next time, I refine for you in 90e39a6#diff-7e0105e342476f0d5cdac59a7217476b

@VikingsFan VikingsFan closed this Aug 10, 2015

@congysu

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2015

Thanks @Ilchert for your contribution. Can you help sign the CLA via the email you received, or via https://cla.microsoft.com.

@congysu congysu reopened this Aug 15, 2015

@congysu

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2015

Pending CLA.

@congysu congysu added this to the v5.7 milestone Aug 15, 2015

@msftclas

This comment has been minimized.

Copy link

commented Aug 15, 2015

@Ilchert, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@msftclas msftclas added cla-signed and removed cla-required labels Aug 15, 2015

@Ilchert

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2015

Sorry for delay with CLA.

@congysu

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2015

Thanks @Ilchert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.