New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.OData.Client 7.0+ needs to support GetValue like the older OData Client #1011

Closed
ImGonaRot opened this Issue Dec 8, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@ImGonaRot

ImGonaRot commented Dec 8, 2017

Current users that have the Microsoft.OData.Client below 7.0 could use GetValue in non-async methods on the clients.

There are tons of examples on the Internet on using GetValue with the OData Client.
Some developers (like me) are using Winforms and in some cases are not allow to use async methods in some of the code and as such will not be able to use the OData Client 7.0+ without creating wrapper methods to call BeginGetValue and EndGetValue.

This also breaks all current T4 template proxy generators like connected services and OData client generator.
The T4 template proxy generator (connected services) is also broken because "Microsoft.OData.Edm.Csdl.EdmxReader.Parse(reader)" change to "Microsoft.OData.Edm.Csdl.CsdlReader.Parse(reader)"

Assemblies affected

Microsoft.OData.Client 7.0+

@xuzhg xuzhg added the feature label Dec 8, 2017

@AlanWong-MS AlanWong-MS referenced this issue Dec 18, 2017

Merged

Adding OData Client Net45 binary #1018

2 of 2 tasks complete
@AlanWong-MS

This comment has been minimized.

Contributor

AlanWong-MS commented Dec 18, 2017

Thanks for the feedback @ImGonaRot. We're adding back the OData Client Net45 library so that the sync versions come back. This is exactly what we needed to hear to make informed decisions. Our OData 7.4 beta 2 release will include the Net45 lib, per PR #1018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment