New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODL 7.x no longer writes type annotations for resource collections in full metadata #1086

Open
mikepizzo opened this Issue Feb 18, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@mikepizzo
Member

mikepizzo commented Feb 18, 2018

ODL 6.x wrote type annotations for resource collections in full metadata. ODL 7.x no longer does so.

Assemblies affected

OData .Net lib 7.x.

Reproduce steps

Write an expanded collection of resources in full metadata.

Expected result

In ODL 6.x, these would be written with the type annotation.

Actual result

In ODL 7.x., the type annotation is missing.

Additional Info

By spec, the type annotation for nested collections and resources is not strictly required, even in full metadata. But, since we wrote this information in ODL 6.x, we should continue to write in ODL 7.x. We can omit this in 4.01.

@tloten

This comment has been minimized.

tloten commented Jul 27, 2018

I've run into this issue - my odata server is using ODL v7.2, and a number of it's clients are using ODL v6.13.
If I bump the server to v7.5, the v6.13 clients that are issuing requests in the form:
client.Widgets.AddQueryOption("$expand", "Children($select=Id)").ToList();
will fail as the client isn't able to process the type annotation that is now present.

I notice the pull-request had a reverted commit that looked like the compatiblity mode would allow control over the annotation. Was there a reason that was reverted/omitted?
Happy to provide more details if required, or I can make a new issue if that's better. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment