New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionCallBinder issue when case-insensitive is enabled #1155

Closed
biaol-odata opened this Issue Apr 26, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@biaol-odata
Member

biaol-odata commented Apr 26, 2018

In ODL, when case-insensitive is enabled, FunctionCallBinder.BindAsUriFunction() essentically does a lower-case search for matching function names.

string functionCallTokenName = this.state.Configuration.EnableCaseInsensitiveUriFunctionIdentifier ? functionCallToken.Name.ToLowerInvariant() : functionCallToken.Name;

This does not work for custom uri functions, returning error message with incorrect function name.
The following WebAPI test fails when enableCaseInsensitive is set to true.
https://github.com/OData/WebApi/blob/master/test/E2ETest/Microsoft.Test.E2E.AspNet.OData/UnboundOperation/UnboundOperationTest.cs#L326

Assemblies affected

7.4.4 and below.

Reproduce steps

See description.

Expected result

Test UnboundOperationTest pass when case-insensitive is enabled.

Actual result

Test UnboundOperationTest failed with error message indicating incorrect function name.

Additional detail

Optional, details of the root cause if known. Delete this section if you have no additional details to add.

@biaol-odata biaol-odata self-assigned this Apr 26, 2018

@biaol-odata biaol-odata added the P2 label Apr 26, 2018

@biaol-odata

This comment has been minimized.

Member

biaol-odata commented May 30, 2018

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment