Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket collection literals should be represented separately from ConstantNode #1164

Open
AlanWong-MS opened this issue May 15, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@AlanWong-MS
Copy link
Contributor

commented May 15, 2018

As of ODL 7.4.x, bracket collection literals (e.g. [1,2,3]) are represented as ConstantNode.

/// <summary>
/// Node representing a constant value, can either be primitive, complex, entity, or collection value.
/// </summary>
public sealed class ConstantNode : SingleValueNode

This creates ambiguity as the literal is a collection, yet it's created as a SingleValueNode. The ideal approach is to have a separate CollectionConstantNode that derives from CollectionNode. However, adjusting this logic for bracket collection literals would be a breaking change, so we should consider this change for the next version of ODL.

Assemblies affected

ODL 7.x

Reproduce steps

See ConstantNode implementation.

@AlanWong-MS AlanWong-MS added the P4 label May 15, 2018

@KanishManuja-MS

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

@mikepizzo This is another breaking change associated with changing parentheses to brackets.

@KanishManuja-MS

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

While this may not be fully fixed with regards to collections in general. It is fixed for the In operator and therefore is not really concerning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.